GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "GH-128914: Remove conditional stack effects from `bytecodes.c` and the code generators (GH-128918)" by colesbury · Pull Request #129202 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jan 22, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The commit introduced a ~2.5-3% regression in the free threading build.

This reverts commit ab61d3f.

  • Issue: Get rid of conditional inputs and outputs for instructions in bytecodes.c #128914

📚 Documentation preview 📚: https://cpython-previews--129202.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
Revert "pythonGH-128914: Remove conditional stack effects from `bytec…
f60435e 
…odes.c` and the code generators (pythonGH-128918)"

The commit introduced a ~2.5-3% regression in the free threading build.

This reverts commit ab61d3f.
@colesbury colesbury added the skip news label Jan 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 22, 2025
Get rid of conditional inputs and outputs for instructions in bytecodes.c #128914
Closed
@colesbury

colesbury commented Jan 22, 2025

Copy link
Copy Markdown
Contributor Author

Benchmarks for the free threading build:

  • For the revert
  • For the original comit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury marked this pull request as ready for review January 22, 2025 22:30
@colesbury
colesbury requested review from Fidget-Spinner, ericsnowcurrently, iritkatriel and markshannon as code owners January 22, 2025 22:30
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 22, 2025
markshannon
markshannon approved these changes Jan 23, 2025
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 23, 2025
@markshannon
markshannon merged commit a10f993 into python:main Jan 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 23, 2025
@diegorusso diegorusso mentioned this pull request Jan 23, 2025
GH-128914: Remove conditional stack effects from bytecodes.c and the code generators #128918
Merged
@colesbury
colesbury deleted the revert-gh-128914 branch February 14, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.