GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119182: Use public PyUnicodeWriter in ast_unparse.c by vstinner · Pull Request #129208 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 23, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API.

  • Add append_char() function.
  • Add APPEND_CHAR() and APPEND_CHAR_FINISH() macros.
  • Replace APPEND_STR() and APPEND_STR_FINISH() of single character with APPEND_CHAR() and APPEND_CHAR_FINISH().
  • Issue: [C API] Add an efficient public PyUnicodeWriter API #119182

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-119182: Use public PyUnicodeWriter in ast_unparse.c
ede98e4 
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API.

* Add append_char() function.
* Add APPEND_CHAR() and APPEND_CHAR_FINISH() macros.
* Replace APPEND_STR() and APPEND_STR_FINISH() of single character
  with APPEND_CHAR() and APPEND_CHAR_FINISH().
@vstinner vstinner added the skip news label Jan 23, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 23, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 23, 2025
[C API] Add an efficient public PyUnicodeWriter API #119182
Closed
@vstinner
vstinner merged commit 8eb9e76 into python:main Jan 23, 2025
@vstinner
vstinner deleted the unparse_writer branch January 23, 2025 00:44
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 23, 2025
@vstinner vstinner mentioned this pull request Jan 24, 2025
gh-128863: Deprecate the private _PyUnicodeWriter API #129245
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.