GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91048: Improve example in `asyncio-graph.rst` doc by sobolevn · Pull Request #129224 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 23, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I propose adding an explicit name, because it is not clear what "Task-1" and "Task-2" are. Now with this explicit name it is more readable.

📚 Documentation preview 📚: https://cpython-previews--129224.org.readthedocs.build/

  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
Improve example in asyncio-graph.rst doc
dd8fc1e
@sobolevn
sobolevn requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners January 23, 2025 13:42
@bedevere-app bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Jan 23, 2025
@sobolevn sobolevn added the skip issue label Jan 23, 2025
@picnixz picnixz changed the title Improve example in asyncio-graph.rst doc gh-91048: Improve example in asyncio-graph.rst doc Jan 23, 2025
@picnixz picnixz removed the skip issue label Jan 23, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 23, 2025
Async Call-Stack Reconstruction #91048
Closed
StanFromIreland
StanFromIreland approved these changes Jan 23, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this will make it clearer for people less familiar with tasks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303
kumaraditya303 approved these changes Jan 23, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 23, 2025
@kumaraditya303
kumaraditya303 merged commit c05a851 into python:main Jan 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @kumaraditya303 @StanFromIreland @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.