GeezerVison is showing github.com — gh-119182: Use public PyUnicodeWriter in _json.c by vstinner · Pull Request #129249 · python/cpython
Conversation
vstinner
commented
Jan 23, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a plan for _PyUnicodeWriter_IsEmpty?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Have a plan for _PyUnicodeWriter_IsEmpty?
My plan is to leave it in _json.c for now :-) I would prefer to not make it public, unless more people ask for such feature.
Also, the function can be removed and replaced with an empty variable. I just tried to minimize changes in my PR.
|
cmaloney reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
cmaloney
cmaloney approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.