GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129223: Raise KeyError in search_map_for_section() if not found by vstinner · Pull Request #129262 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 24, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: The compiler may optimise away globals with debug offsets #129223

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Jan 24, 2025
@vstinner vstinner self-assigned this Jan 24, 2025
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Jan 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 24, 2025
The compiler may optimise away globals with debug offsets #129223
Closed
@vstinner
pythongh-129223: Raise KeyError in search_map_for_section() if not found
c8c5241
@vstinner
vstinner force-pushed the search_map_for_section branch from 266eeee to c8c5241 Compare January 24, 2025 13:49
@vstinner

vstinner commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

@pablogsal @ambv @encukou: This change fix the SystemError in test_external_inspection on Fedora Stable with LTO.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jan 24, 2025
GH-91048: Add utils for capturing async call stack for asyncio programs and enable profiling #124640
Merged
5 of 6 tasks
@ambv

ambv commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

I'm not crazy about this approach because silently skipping tests when we couldn't find a section on a platform that we expected to be able to find the section is a bug. The fix in #129225 actually addresses the problem, which was the compiler optimizing away debug sections unless __attribute__((used)) was used.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

I can modify my PR to not skip the tests on KeyError.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jan 25, 2025

Copy link
Copy Markdown
Member

I can modify my PR to not skip the tests on KeyError.

This should be fixed by the real fix #129225. Please, let's remove the skips because that will be masking actual errors that we want to fix. Let's merge the PR with the new raising of KeyError 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Don't skip the tests
66f2f40
@vstinner

vstinner commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

@ambv @pablogsal: Ok, I modified my PR only to fix the SystemError, tests are no longer skipped.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit be98fda into python:main Jan 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 25, 2025
@vstinner
vstinner deleted the search_map_for_section branch January 25, 2025 20:12
@sergey-miryanov sergey-miryanov mentioned this pull request Feb 21, 2025
gh-130052: Fix some exceptions on error paths in _testexternalinspection #130053
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @ambv @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.