GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112632 : Added an option for block formatting to ``pprint`` by StefanTodoran · Pull Request #129274 · python/cpython

Conversation

@StefanTodoran

@StefanTodoran StefanTodoran commented Jan 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds a block print option to pprint. This option is not compatible with compact. Although the original issue only mentions dictionaries, this implementation implements block style for every datastructure supported by pprint. I've been testing it with the code in this gist, which is just a bunch of random datastructures filled with dummy data.

  • Issue: pprint with compact indent #112632

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8, donbarbos, and hyzyla reacted with thumbs up emoji sujaldev, synchronizing, and hyzyla reacted with heart emoji
All reactions
  • 👍 3 reactions
  • ❤️ 3 reactions
@stodoran
Added an option for block formatting to pprint
b9baf94
@ghost

ghost commented Jan 25, 2025 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jan 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 25, 2025
pprint with compact indent #112632
Closed
@bedevere-app

bedevere-app Bot commented Jan 25, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
tomasr8 self-requested a review January 25, 2025 09:29
@donbarbos

donbarbos commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

looks pretty good 👍, but

  • I think you can move test cases from your gist to Lib/test/test_pprint.py.
  • It is also important to update documentation, you'll find them here Doc/library/pprint.rst.

And please try to make sure CI passes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran
Small bug fix for indent=1, added to unit test
f5fcbfc
@bedevere-app

bedevere-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran
Merge branch 'main' into fix-issue-112632
31a4d1e
@bedevere-app

bedevere-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran
Remove set from block style unit test (since order kept changing)
a92ef3d
@bedevere-app

bedevere-app Bot commented Feb 7, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos

donbarbos commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Could you also add a News entry into the Misc/NEWS.d (check bedevere's comments)?

And I think it's a full fledged new feature so this update deserves to be in Doc/whatsnew/ (What's New entry)
StefanTodoran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran

StefanTodoran commented Feb 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I've added a test case for the new block_style parameter and updated the documentation. Will add the news entry now. Quick question:

  • How can I make the CI pass? I've only changed Lib.pprint.py and I pass Lib/test/test_pprint.py, so I don't understand why exactly the Tests / Thread sanitizer (free-threading) CI test is failing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos

donbarbos commented Feb 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

How can I make the CI pass? I've only changed Lib.pprint.py and I pass Lib/test/test_pprint.py, so I don't understand why exactly the Tests / Thread sanitizer (free-threading) CI test is failing.

sometimes the problem may not be in you and you need to wait and update your branch (at least it helped me)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blurb-it Bot and others added 3 commits February 7, 2025 00:48
@blurb-it
📜🤖 Added by blurb_it.
d9a147f
@StefanTodoran
Merge branch 'main' into fix-issue-112632
ffef3b0
@StefanTodoran
Fix params in news entry
19e4e08
donbarbos
donbarbos reviewed Feb 7, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-02-07-00-48-07.gh-issue-112632.95MM0C.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran
Fix line length for news entry
8ef085f
donbarbos
donbarbos reviewed Feb 7, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-02-07-00-48-07.gh-issue-112632.95MM0C.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
StefanTodoran added 2 commits February 6, 2025 17:58
@StefanTodoran
Shorten news entry
c446aa1
@StefanTodoran
Merge branch 'main' into fix-issue-112632
f9bd6ef
donbarbos
donbarbos reviewed Feb 9, 2025
View reviewed changes
Comment thread Doc/library/pprint.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
donbarbos
donbarbos reviewed Feb 9, 2025
View reviewed changes
Comment thread Lib/test/test_pprint.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos

donbarbos commented Feb 9, 2025

Copy link
Copy Markdown
Contributor

and don't forget to add news to Doc/whatsnew/3.14.rst

And I think it's a full fledged new feature so this update deserves to be in Doc/whatsnew/ (What's New entry)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StefanTodoran added 3 commits February 19, 2025 10:23
@StefanTodoran
Address documentation related PR comments
49b1108
@StefanTodoran
Merge branch 'main' into fix-issue-112632
62dd5e5
@StefanTodoran
Fix length of title underline :/
0b8fd2b
StefanTodoran and others added 10 commits February 25, 2025 08:49
@StefanTodoran @donbarbos
Update Lib/pprint.py
5abab85 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/pprint.py
5e8a624 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
5ffbd0d 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
fa4cdac 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
6bffc7e 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
c8ce4ff 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
879f1da 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
21c9fa6 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran @donbarbos
Update Lib/test/test_pprint.py
815e1da 
Co-authored-by: donBarbos <[email protected]>
@StefanTodoran
Merge branch 'main' into fix-issue-112632
9d12a8a
@StefanTodoran

StefanTodoran commented Feb 25, 2025

Copy link
Copy Markdown
Contributor Author

I've merged those changes. Thanks for helping me out with that! Is there anything else?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos

donbarbos commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

I've merged those changes. Thanks for helping me out with that! Is there anything else?

Let's try to solve problems with test_pprint.QueryTestCase.test_block_style
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
donbarbos
donbarbos reviewed Feb 25, 2025
View reviewed changes
Comment thread Lib/test/test_pprint.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
donbarbos
donbarbos reviewed Feb 25, 2025
View reviewed changes
Comment thread Lib/test/test_pprint.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran @donbarbos
Apply suggestions from code review
a7c26dd 
Co-authored-by: donBarbos <[email protected]>
@donbarbos

donbarbos commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

I think we can ping @tomasr8 if you're done making changes.
StefanTodoran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran

StefanTodoran commented Feb 26, 2025

Copy link
Copy Markdown
Contributor Author

Sounds good, I have no more changes to add.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8
tomasr8 reviewed Feb 26, 2025
View reviewed changes

@tomasr8 tomasr8 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's looking pretty good now! Just two comments:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/pprint.py
stream.write(cls.__name__ + '({')
if self._indent_per_level > 1:
stream.write(self._format_block_start(cls.__name__ + '({', indent))
if self._indent_per_level > 1 and not self._block_style:

@tomasr8 tomasr8 Feb 26, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not covered by tests (the condition is always False).

For such a large change, I suggest running coverage and checking the html report to make sure your tests cover all cases. There's a guide here, but the gist is:

./python -m ensurepip
./python -m pip install coverage
./python -m coverage run --pylib --source=pprint Lib/test/regrtest.py test_pprint
./python -m coverage html -i --include=`pwd`/Lib/* --omit="Lib/test/*,Lib/*/tests/*"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@StefanTodoran StefanTodoran Mar 28, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, what do you mean the case is not covered? The existing tests already covered the case where _block_style is False and _indent_per_level is >1.

Also when I run the coverage command I don't see anything missing, am I doing something wrong?

python3 -m coverage run --pylib --source=pprint Lib/test/regrtest.py test_pprint
/Users/stodoran/Desktop/cpython/venv/lib/python3.13/site-packages/coverage/inorout.py:486: CoverageWarning: Already imported a file that will be measured: /opt/homebrew/Cellar/[email protected]/3.13.2/Frameworks/Python.framework/Versions/3.13/lib/python3.13/pprint.py (already-imported)
  self.warn(msg, slug="already-imported")
Using random seed: 4261013096
0:00:00 load avg: 4.87 Run 1 test sequentially in a single process
0:00:00 load avg: 4.87 [1/1] test_pprint

== Tests result: SUCCESS ==

1 test OK.

Total duration: 129 ms
Total tests: run=44
Total test files: run=1/1
Result: SUCCESS

python3 -m coverage html -i --include=`pwd`/Lib/* --omit="Lib/test/*,Lib/*/tests/*"
No data to report.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tomasr8 tomasr8 Apr 5, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see it's not covered:
image

I think there's some issue with the coverage command you ran as it says:

No data to report.

Try running it with the compiled binary directly, not with some other system python.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@donbarbos donbarbos Apr 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanTodoran if you can't get HTML-based report you can use cli:

$ ./python -m coverage report --show-missing
Name            Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------
Lib/pprint.py     476     81    182      7    87%   37-46, 57, 67-72, 77, 82, 87-99, 102, 110, 115-116, 172, 174-177, 182, 185, 189, 192-195, 220, 226, 232, 243-245, 262-264, 276-278, 284-286, 293-295, 312-315, 353->326, 367-369, 388-390, 400-402, 409-411, 424-426, 444, 464, 507, 513, 516, 523, 537-539, 546, 556-558, 560-561, 573-575, 595-597, 600-602, 605-607, 610-612, 694, 703, 717->exit
-----------------------------------------------------------
TOTAL             476     81    182      7    87%

I don't know why on the main branch this line is shown as covered, but this can be solved by adding an explicit pass of indent>1 to the QueryTestCase.test_counter test, like this:

        d = collections.Counter('senselessness')
        self.assertEqual(pprint.pformat(d, indent=2, width=1),
"""\
Counter({ 's': 6,
          'e': 4,
          'n': 2,
          'l': 1})""")

and the line will become covered 👍
(unfortunately i can't send you a suggestion as there is no diff nearby, so please add it yourself)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lordmauve
lordmauve reviewed Mar 25, 2025
View reviewed changes
Comment thread Lib/pprint.py
Comment on lines -252 to +282
stream.write('[')
stream.write(self._format_block_start('[', indent))
self._format_items(object, stream, indent, allowance + 1,
context, level)
stream.write(']')
stream.write(self._format_block_end(']', indent))

@lordmauve lordmauve Mar 25, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a lot of repeated code here conditional on self._block_style. How about defining a context manager to clean this up?

with self._block(stream, indent, '[', ']') as new_indent:
    self._format_items(object, stream, new_indent, allowance + 1,
                       context, level)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
StefanTodoran added 3 commits March 27, 2025 18:21
@StefanTodoran
Split large test case into multiple smaller ones, update news entry
37312d9
@StefanTodoran
Merge branch 'main' into fix-issue-112632
e3b09fa
@StefanTodoran
Merge changes
712b644
@AA-Turner AA-Turner changed the title gh-112632 : Added an option for block formatting to Lib/pprint.py gh-112632 : Added an option for block formatting to pprint Apr 20, 2025
AA-Turner
AA-Turner reviewed Apr 20, 2025
View reviewed changes
Comment thread Doc/library/pprint.rst
Comment on lines +39 to +40
compact=False, sort_dicts=False, underscore_numbers=False, \
block_style=False)

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are keyword-only (after *), so we have the luxury of alphabetical sorting:

Suggested change
compact=False, sort_dicts=False, underscore_numbers=False, \
block_style=False)
block_style=False, compact=False, sort_dicts=False, \
underscore_numbers=False)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/pprint.rst
Comment on lines +110 to +111
compact=False, sort_dicts=True, \
underscore_numbers=False, block_style=False)

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

Suggested change
compact=False, sort_dicts=True, \
underscore_numbers=False, block_style=False)
block_style=False, compact=False, \
sort_dicts=True, underscore_numbers=False)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/pprint.rst
If ``True``,
opening parentheses and brackets will be followed by a newline and the
following content will be indented by one level, similar to block style
JSON formatting. This option is not compatible with *compact*.

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is not compatible with compact.

A passing thought: Perhaps introduce a mode (str) argument, and deprecate compact in favour of it? It's not great to have two conflicting Booleans, though it may be the best option for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/pprint.rst
Comment on lines +119 to +120
compact=False, sort_dicts=True, \
underscore_numbers=False, block_style=False)

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

Suggested change
compact=False, sort_dicts=True, \
underscore_numbers=False, block_style=False)
block_style=False, compact=False, \
sort_dicts=True, underscore_numbers=False)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/pprint.rst
Comment on lines +167 to +168
compact=False, sort_dicts=True, \
underscore_numbers=False, block_style=False)

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

Suggested change
compact=False, sort_dicts=True, \
underscore_numbers=False, block_style=False)
block_style=False, compact=False, \
sort_dicts=True, underscore_numbers=False)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pprint.py
Comment on lines +117 to +118
compact=False, sort_dicts=True, underscore_numbers=False,
block_style=False):

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compact=False, sort_dicts=True, underscore_numbers=False,
block_style=False):
block_style=False, compact=False, sort_dicts=True,
underscore_numbers=False):

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pprint.py
Comment on lines +146 to +147
pretty-printed json.dumps() when `indent` is supplied. Incompatible
with compact mode.

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pretty-printed json.dumps() when `indent` is supplied. Incompatible
with compact mode.
pretty-printed json.dumps() when ``indent`` is supplied.
Incompatible with compact mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pprint.py
Comment on lines +223 to +224
else:
return start_str

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else:
return start_str
return start_str

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pprint.py
Comment on lines +229 to +230
else:
return end_str

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else:
return end_str
return end_str

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/pprint.py

cls_name = object.__class__.__name__
indent += len(cls_name) + 1
indent += len(cls_name) + 1 if not self._block_style else self._indent_per_level

@AA-Turner AA-Turner Apr 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep to 79/80 characters (PEP 8)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@donbarbos

donbarbos commented May 31, 2025

Copy link
Copy Markdown
Contributor

@StefanTodoran I think your PR is useful, maybe you can tell if you'll continue working and if so when you can continue working
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanTodoran

StefanTodoran commented Jun 1, 2025

Copy link
Copy Markdown
Contributor Author

@donbarbos Sorry about the radio silence, due to work responsibilities my bandwidth is too limited to devote time to this change right now. I can give access to my fork of the repo if someone wants to pick up where I left off.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos

donbarbos commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

@donbarbos Sorry about the radio silence, due to work responsibilities my bandwidth is too limited to devote time to this change right now. I can give access to my fork of the repo if someone wants to pick up where I left off.

thanks, i will be glad to finish this work. but as far as i know the usual practice is to open a new PR, so i can fork your branch and send a new PR to be able to control the PR discussion
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos donbarbos mentioned this pull request Jul 22, 2025
gh-112632: Add optional keyword-only argument expand to pprint #136964
Merged
@hugovk

hugovk commented Mar 28, 2026

Copy link
Copy Markdown
Member

Closing in favour of #136964, thanks all.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk closed this Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 left review comments
@AA-Turner AA-Turner AA-Turner left review comments
+2 more reviewers
@lordmauve lordmauve lordmauve left review comments
@donbarbos donbarbos donbarbos requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@StefanTodoran @donbarbos @hugovk @lordmauve @tomasr8 @AA-Turner @stodoran
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.