GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — simplify test_asyncio.test_taskgroups no_other_refs by graingert · Pull Request #129284 · python/cpython

Conversation

@graingert

@graingert graingert commented Jan 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

we can now go directly from frame to generator, so that simplifies the no_other_refs code in test_taskgroups quite a bit.

There's still #125640 to obviate this entirely

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
simplify test_asyncio.test_taskgroups no_other_refs
1e7e952
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 25, 2025
@graingert graingert added skip issue skip news labels Jan 25, 2025
@graingert
Merge branch 'main' into simplify-no-other-refs
a8c18b2
@graingert
graingert requested a review from markshannon January 25, 2025 09:19
@graingert
graingert marked this pull request as ready for review January 25, 2025 09:24
@graingert
graingert requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners January 25, 2025 09:24
@bedevere-app bedevere-app Bot added the awaiting review label Jan 25, 2025
@kumaraditya303

kumaraditya303 commented Jan 25, 2025

Copy link
Copy Markdown
Contributor

I think we should just wait for #125640 to be merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 21, 2026
@graingert
Merge branch 'main' into simplify-no-other-refs
ec4b4f8
@graingert

graingert commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

I think we should just wait for #125640 to be merged.

looks like that PR went stale
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.