GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-129061: Fix `FORCE_COLOR` and `NO_COLOR` when empty strings (GH-129140) by miss-islington · Pull Request #129360 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 27, 2025 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 9546fe2)

Co-authored-by: Hugo van Kemenade [email protected]

Fixes #129061.

  • Issue: Empty values of FORCE_COLOR and NO_COLOR are not ignored #129061

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk @miss-islington
pythongh-129061: Fix FORCE_COLOR and NO_COLOR when empty strings (p…
a8eeea9 
…ythonGH-129140)

(cherry picked from commit 9546fe2)

Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington
miss-islington requested a review from hugovk as a code owner January 27, 2025 14:24
@bedevere-app bedevere-app Bot added the awaiting review label Jan 27, 2025
This was referenced Jan 27, 2025
gh-129061: Fix FORCE_COLOR and NO_COLOR when empty strings #129140
Merged
Empty values of FORCE_COLOR and NO_COLOR are not ignored #129061
Closed
@hugovk
hugovk enabled auto-merge (squash) January 27, 2025 14:26
@hugovk
hugovk merged commit c7f9e74 into python:3.13 Jan 27, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 27, 2025
@miss-islington
miss-islington deleted the backport-9546fe2-3.13 branch January 2, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.