GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126609: Revert Availability Directive changes by StanFromIreland · Pull Request #129480 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jan 30, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Availability extension's text translation breaks directive rendering #126609

📚 Documentation preview 📚: https://cpython-previews--129480.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
Revert Availability Directive move
74d5a8e
@StanFromIreland
StanFromIreland requested review from AA-Turner and hugovk as code owners January 30, 2025 18:06
@bedevere-app bedevere-app Bot added the awaiting review label Jan 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2025
Availability extension's text translation breaks directive rendering #126609
Closed
m-aciek
m-aciek requested changes Jan 30, 2025
View reviewed changes

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not revert the move, but just the changes that were made in the directive class.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jan 30, 2025
StanFromIreland added 2 commits January 30, 2025 18:26
@StanFromIreland
Revert "Revert Availability Directive move"
218f23a 
This reverts commit 74d5a8e.
@StanFromIreland
Revert Availability Directive changes
b9f7e04
@StanFromIreland

StanFromIreland commented Jan 30, 2025

Copy link
Copy Markdown
Member Author

@m-aciek Reverted just changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland added 2 commits January 30, 2025 18:30
@StanFromIreland
Add setup
2055ace
@StanFromIreland
Clean up Lint
fd05919
@StanFromIreland StanFromIreland changed the title gh-126609: Revert Availability Directive move gh-126609: Revert Availability Directive changes Jan 30, 2025
@StanFromIreland
StanFromIreland requested a review from m-aciek January 30, 2025 18:32
StanFromIreland added 3 commits January 30, 2025 18:36
@StanFromIreland
Clean up Lint
1a95fb6
@StanFromIreland
Clean up Lint
2b34fb3
@StanFromIreland
Clean up Lint
60d3f7a
@m-aciek

m-aciek commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

I've opened a more minimal revert: #129482
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Jan 30, 2025

Copy link
Copy Markdown
Member Author

Closed for #129482
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland closed this Jan 30, 2025
@StanFromIreland
StanFromIreland deleted the revert-avail-move branch January 30, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@m-aciek m-aciek Awaiting requested review from m-aciek

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@StanFromIreland @m-aciek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.