GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128317: Move CLI calendar highlighting to private class by hugovk · Pull Request #129625 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Feb 3, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Following @encukou's suggestions in #128317 (comment).

I've added a NEWS file because #128318 went out in 3.14a4, so I think this warrants one?

  • Issue: Highlight today in colour in calendar's CLI output #128317

📚 Documentation preview 📚: https://cpython-previews--129625.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 3 commits February 3, 2025 22:03
@hugovk
Put CLI calendar highlighting in private class
a6da663
@hugovk
Add __init__ with self.highlight_day = highlight_day
2ddd90e
@hugovk
Add blurb
c148bde
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 3, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 3, 2025
Highlight today in colour in calendar's CLI output #128317
Closed
@hugovk
Fix blurb
52fb36d
encukou
encukou approved these changes Feb 8, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

I'm not sure what the next step should be -- perhaps the API should be improved to make this kind of customization easier; perhaps CLICalendar should be public. But, in plain text, avoiding terminal sequences is the right thing to do.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2025-02-03-22-31-43.gh-issue-128317.n2Swnh.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 8, 2025
@hugovk @encukou
Fix typo
4424ea9 
Co-authored-by: Petr Viktorin <[email protected]>
@hugovk

hugovk commented Feb 8, 2025

Copy link
Copy Markdown
Member Author

And thanks for the review!

Re: next steps, I'm not planning on further changes to the calendar right now, although if the week numbering idea progresses, we can consider things like that.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Merge branch 'main' into 3.14-_CLIDemoCalendar2
22599d5
@hugovk
hugovk enabled auto-merge (squash) February 8, 2025 14:55
@hugovk
hugovk merged commit 1bccd6c into python:main Feb 8, 2025
@hugovk
hugovk deleted the 3.14-_CLIDemoCalendar2 branch February 8, 2025 15:56
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 8, 2025
@hugovk hugovk mentioned this pull request Feb 28, 2025
test_calendar and test_pdb always fail in non-English locale #130665
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.