GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-21536: Revert Makefile change on python-config by vstinner · Pull Request #12971 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 26, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Misc/python-config.sh lives in the build directory, not in the source
directory.

https://bugs.python.org/issue21536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-21536: Revert Makefile change on python-config
0b069e4 
Misc/python-config.sh lives in the build directory, not in the source
directory.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 26, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Apr 26, 2019
@vstinner vstinner added the skip news label Apr 26, 2019
@vstinner

vstinner commented Apr 26, 2019

Copy link
Copy Markdown
Member Author

When I build Python of the source tree, I can reproduce the bug without my change:

make: *** No rule to make target '/path_to_build_dir/Misc/python-config.sh', needed by 'python-config'.  Stop

I confirm with manual test that my change fix this use case.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 01f073f into python:master Apr 26, 2019
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 26, 2019
@vstinner
vstinner deleted the revert_makefile branch April 26, 2019 15:55
@pitrou pitrou mentioned this pull request Sep 2, 2022
extension built with a shared python cannot be loaded with a static python #65735
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.