GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/_collectionsmodule.c` by picnixz · Pull Request #129773 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Feb 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 6 commits January 25, 2025 18:00
@picnixz
fix UBSan failures for dequeobject
22e4df8
@picnixz
fix UBSan failures for dequeiterobject
a19302d
@picnixz
fix UBSan failures for defdictobject
7a6384e
@picnixz
fix UBSan failures for tuplegetterobject
6268c5e
@picnixz
suppress unused return values
337cb29
@picnixz
use 'dummy' for NOARGS method
cd3775b
@picnixz picnixz added the skip news label Feb 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 7, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@picnixz picnixz changed the title gh-111178: fix UBSan failures in $where gh-111178: fix UBSan failures in Modules/_collectionsmodule.c Feb 7, 2025
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/collectio…
e825058 
…ns-111178
@picnixz
picnixz marked this pull request as ready for review February 7, 2025 18:06
@picnixz
picnixz requested a review from rhettinger as a code owner February 7, 2025 18:06
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 7, 2025
@picnixz

picnixz commented Feb 7, 2025

Copy link
Copy Markdown
Member Author

Ah I'm sorry I put this one as ready for review but I learned that _ + capital letter was also UB (#128248 (comment)). Even though _ + lowercase letter is not UB (hopefully), this one can be reviewed. However, for consistency, I'll also remove the _ tomorrow along with the other PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Do not add an underscore to the macro if none is needed.
46da2c4
chris-eibl
chris-eibl reviewed Feb 8, 2025
View reviewed changes
Comment thread Modules/_collectionsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz commented Feb 8, 2025
View reviewed changes
Comment thread Modules/_collectionsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_collectionsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Remove unnecessary cast
b245b68
encukou
encukou approved these changes Feb 17, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 17, 2025
@picnixz
Merge branch 'main' into fix/ubsan/collections-111178
ef6141a
@picnixz
picnixz enabled auto-merge (squash) February 17, 2025 11:50
@picnixz
picnixz merged commit f55d0b6 into python:main Feb 17, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 17, 2025
@picnixz
picnixz deleted the fix/ubsan/collections-111178 branch February 17, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl left review comments
@encukou encukou encukou approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @encukou @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.