GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/itertoolsmodule.c` by picnixz · Pull Request #129780 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Feb 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 23 commits February 6, 2025 13:06
@picnixz
fix UBSan failures for batchedobject
ef9f762
@picnixz
fix UBSan failures for pairwiseobject
8cfd9f3
@picnixz
fix UBSan failures for groupbyobject
a50c28f
@picnixz
fix UBSan failures for _grouperobject
c61c1da
@picnixz
fix UBSan failures for teedataobject
7a02ffc
@picnixz
fix UBSan failures for teeobject
b0f971a
@picnixz
fix UBSan failures for cycleobject
8dc8779
@picnixz
fix UBSan failures for dropwhileobject
27e83cf
@picnixz
fix UBSan failures for takewhileobject
517b00e
@picnixz
fix UBSan failures for isliceobject
5b3b086
@picnixz
fix UBSan failures for starmapobject
b3a53d3
@picnixz
fix UBSan failures for chainobject
02d3695
@picnixz
fix UBSan failures for productobject
d45dc28
@picnixz
fix UBSan failures for combinationsobject
36a1b3c
@picnixz
fix UBSan failures for cwrobject
56b1dcc
@picnixz
fix UBSan failures for permutationsobject
8bcb250
@picnixz
fix UBSan failures for accumulateobject
b772394
@picnixz
fix UBSan failures for compressobject
b9b3f16
@picnixz
fix UBSan failures for filterfalseobject
658ef78
@picnixz
fix UBSan failures for countobject
e780c70
@picnixz
fix UBSan failures for repeatobject
b376791
@picnixz
fix UBSan failures for ziplongestobject
b6ebab3
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/itertools…
dff40b4 
…-111178
@picnixz picnixz added the skip news label Feb 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 7, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@picnixz picnixz changed the title gh-111178: fix UBSan failures in Modules/_itertoolsmodule.c gh-111178: fix UBSan failures in Modules/itertoolsmodule.c Feb 7, 2025
@picnixz
picnixz marked this pull request as ready for review February 8, 2025 09:39
@picnixz
picnixz requested a review from rhettinger as a code owner February 8, 2025 09:39
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 8, 2025
@encukou
Merge branch 'main' into fix/ubsan/itertools-111178
5f66aec
encukou
encukou reviewed Feb 18, 2025
View reviewed changes
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Restore a cast
b94e7c5
@encukou
encukou merged commit f8c041b into python:main Feb 19, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 19, 2025
@picnixz
picnixz deleted the fix/ubsan/itertools-111178 branch February 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.