GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Feb 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 4 commits January 25, 2025 16:29
@picnixz
fix UBSan failures for TkappObject
cfced14
@picnixz
fix UBSan failures for PyTclObject
d2b723d
@picnixz
fix UBSan failures for TkttObject
8c0e55e
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/tkinter-1…
5b6a755 
…11178
@picnixz picnixz added the skip news label Feb 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 7, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
picnixz added 2 commits February 8, 2025 10:20
@picnixz
Do Do not use _ + capital letter in new code as it is also UB.
9662528
@picnixz
fix compilation
6df44b6
@picnixz
picnixz marked this pull request as ready for review February 8, 2025 09:37
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 8, 2025
@encukou
Merge branch 'main' into fix/ubsan/tkinter-111178
49fc5c6
encukou
encukou reviewed Feb 24, 2025
View reviewed changes
Comment thread Modules/_tkinter.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz marked this pull request as draft February 24, 2025 13:14
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 24, 2025
@picnixz
remove unused TkttObject_FAST_CAST macro
08efc4c
@picnixz

picnixz commented Feb 25, 2025

Copy link
Copy Markdown
Member Author

Independently of this PR, but can't we actually transform static types of tkinter into heap types?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
remove redundant macros and improve CHECK_TCL_APPARTMENT
f5f4efc
@picnixz
picnixz marked this pull request as ready for review February 25, 2025 11:32
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 25, 2025
encukou
encukou approved these changes Feb 25, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One nitpick left:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_tkinter.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 25, 2025
@encukou

encukou commented Feb 25, 2025

Copy link
Copy Markdown
Member

Independently of this PR, but can't we actually transform static types of tkinter into heap types?

See #103092 (comment) & #103108
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
implement CHECK_TCL_APPARTMENT as a static inline function
5f2287c
@encukou
encukou merged commit 59d3ad0 into python:main Feb 26, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 26, 2025
@picnixz
picnixz deleted the fix/ubsan/tkinter-111178 branch February 28, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.