GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures in `Objects/typeobject.c` by picnixz · Pull Request #129799 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Feb 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 3 commits February 6, 2025 16:28
@picnixz
fix UBSan failures for PyTypeObject
cb45420
@picnixz
use a macro and remove redundant casts for superobject casts
8caec09
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/typeobjec…
d78434e 
…t-111178
@picnixz picnixz added the skip news label Feb 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 7, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@picnixz
picnixz marked this pull request as ready for review February 7, 2025 18:08
@picnixz
picnixz requested a review from markshannon as a code owner February 7, 2025 18:08
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 7, 2025
vstinner
vstinner reviewed Feb 21, 2025
View reviewed changes
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz marked this pull request as draft February 21, 2025 15:50
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 21, 2025
@picnixz
address Victor's review
3a661a3
@picnixz
picnixz marked this pull request as ready for review February 22, 2025 10:15
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 22, 2025
@picnixz
Merge branch 'main' into fix/ubsan/typeobject-111178
70dacc6
vstinner
vstinner reviewed Feb 22, 2025
View reviewed changes
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
reverting suggestion
73ef441
@picnixz
picnixz requested a review from vstinner February 22, 2025 13:16
vstinner
vstinner approved these changes Feb 24, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 24, 2025
@picnixz
Merge branch 'main' into fix/ubsan/typeobject-111178
3e710c3
@picnixz
picnixz enabled auto-merge (squash) February 25, 2025 10:23
@picnixz
picnixz merged commit 3d40317 into python:main Feb 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 25, 2025
@picnixz
picnixz deleted the fix/ubsan/typeobject-111178 branch February 25, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.