GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128563: Move assignment of opcode into ifdef by Fidget-Spinner · Pull Request #129803 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Feb 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This moves the opcode assignment into the tail call ifdef, to aid with really old compilers that might not be able to optimize it away.

Though we might think a single assignment doesn't matter. I have a feeling it's not optimized away.

See the comment thread from #128563 (comment) onwards for rationale.

  • Issue: A new tail-calling interpreter for significantly better interpreter performance #128563

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Move assignment of opcode into ifdef
232f31d
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner February 7, 2025 12:15
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 7, 2025
@Fidget-Spinner Fidget-Spinner added skip news and removed awaiting core review labels Feb 7, 2025
@Fidget-Spinner
Fidget-Spinner requested a review from iritkatriel February 7, 2025 12:15
@bedevere-app bedevere-app Bot mentioned this pull request Feb 7, 2025
A new tail-calling interpreter for significantly better interpreter performance #128563
Closed
@Fidget-Spinner
Update generated_cases.c.h
793f2d8
iritkatriel
iritkatriel approved these changes Feb 7, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Feb 7, 2025
@Fidget-Spinner
Fidget-Spinner merged commit 1758447 into python:main Feb 7, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 7, 2025
@Fidget-Spinner

Fidget-Spinner commented Feb 7, 2025

Copy link
Copy Markdown
Member Author

Thanks Irit!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner deleted the tail-call-opcode branch February 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.