GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-21536: On Android, C extensions are linked to libpython by xdegaye · Pull Request #12989 · python/cpython

Conversation

@xdegaye

@xdegaye xdegaye commented Apr 27, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue21536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xdegaye added 2 commits April 27, 2019 22:15
@xdegaye
bpo-21536: On Android, C extensions are linked to libpython
d3a4dd6
@xdegaye
bpo-21536: Update the NEWS entry
20a435f
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 27, 2019
@bedevere-bot bedevere-bot added the awaiting review label Apr 27, 2019
auvipy
auvipy approved these changes Apr 28, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 28, 2019
@vstinner
vstinner merged commit 254b309 into python:master Apr 29, 2019
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 29, 2019
@vstinner

vstinner commented Apr 29, 2019

Copy link
Copy Markdown
Member

LGTM. Thanks @xdegaye for this fix!

I tested the PR on Linux: C extensions are still not linked to libpython, as expected.

Xavier tested the cross-compilation to Android.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@embray

embray commented May 24, 2019

Copy link
Copy Markdown
Contributor

Note: This is a follow-up to #12946.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
embray
embray reviewed May 24, 2019
View reviewed changes
Comment thread configure.ac

# On Android the shared libraries must be linked with libpython.
AC_SUBST(LIBPYTHON)
if test -z "$ANDROID_API_LEVEL"; then

@embray embray May 24, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, being that I'm unfamiliar with build issues on Android why the specific test for $ANDROID_API_LEVEL and not something more generic like:

case $host in
    *-linux-android*) ....

?

Reason being, I need to add additional cases where libpython should be linked explicitly (e.g. Cygwin, MinGW, etc.) and it would be easier to build off the host_os for this than something very Android-specific.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@xdegaye xdegaye May 24, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a test based on $ANDROID_API_LEVEL or on $host as you suggest is equivalent.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xdegaye
xdegaye deleted the bpo-21536 branch December 10, 2019 12:20
@pitrou pitrou mentioned this pull request Sep 2, 2022
extension built with a shared python cannot be loaded with a static python #65735
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@embray embray embray left review comments
@auvipy auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@xdegaye @vstinner @embray @auvipy @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.