GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-126554: correct detection of `gcc` for `TestNullDlsym.test_null_dlsym` (GH-129872) by miss-islington · Pull Request #129944 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In case gcc is not available, the test will fail with FileNotFoundError.
So catch the exception to skip the test correctly.
(cherry picked from commit 978211c)

Co-authored-by: Peter Marko [email protected]
Signed-off-by: Peter Marko [email protected]

  • Issue: ctypes: We do not correctly handle NULL dlsym() return values #126554

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@petermarko @miss-islington
pythongh-126554: correct detection of gcc for `TestNullDlsym.test_n…
b9f8346 
…ull_dlsym` (pythonGH-129872)

In case gcc is not available, the test will fail with FileNotFoundError.
So catch the exception to skip the test correctly.
(cherry picked from commit 978211c)

Co-authored-by: Peter Marko <[email protected]>
Signed-off-by: Peter Marko <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Feb 10, 2025
gh-126554: correct detection of gcc for TestNullDlsym.test_null_dlsym #129872
Merged
@bedevere-app bedevere-app Bot added skip news tests Tests in the Lib/test dir awaiting review labels Feb 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 10, 2025
ctypes: We do not correctly handle NULL dlsym() return values #126554
Closed
@picnixz
picnixz enabled auto-merge (squash) February 10, 2025 09:56
@picnixz
picnixz merged commit cef406b into python:3.13 Feb 10, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 10, 2025
@miss-islington
miss-islington deleted the backport-978211c-3.13 branch January 2, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @picnixz @petermarko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.