GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126835: Fold unary & binary complex constant expressions during code generation. by WolframAlph · Pull Request #129963 · python/cpython

Conversation

@WolframAlph

@WolframAlph WolframAlph commented Feb 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Codegen expects unary & binary complex constant expressions already folded. Without it, we cannot proceed with migration of unaryop & binaryop to CFG. cc @Eclips4 @tomasr8

This PR does 2 things:

  1. Implement unary & binary complex constant expression folding in codegen to prepare for binary & unary folding migration.
  2. Make AST optimization optional, to test mentioned changes.

This PR is created in case we decide to go with this approach.

  • Issue: Move const folding to the peephole optimizer #126835

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WolframAlph
fold unary & binary complex constant expressions in codegen
f903eb4
@WolframAlph
WolframAlph requested review from iritkatriel and markshannon as code owners February 10, 2025 16:43
@bedevere-app bedevere-app Bot added the awaiting review label Feb 10, 2025
@WolframAlph
WolframAlph marked this pull request as draft February 10, 2025 16:43
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 10, 2025
Move const folding to the peephole optimizer #126835
Open
@WolframAlph WolframAlph changed the title gh-126835: Fold unary & binary complex constant expressions in codegen gh-126835: Fold unary & binary complex constant expressions during code generation. Feb 10, 2025
WolframAlph added 6 commits February 10, 2025 17:46
@WolframAlph
update tests
185c1c7
@WolframAlph
bring back macro
ac38c1b
@WolframAlph
add macros
013a890
@WolframAlph
update macros
8c08228
@WolframAlph
update tests
6aec21e
@WolframAlph
regen files
c17e710
@WolframAlph

WolframAlph commented Feb 15, 2025

Copy link
Copy Markdown
Contributor Author

Used different approach in the end.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WolframAlph WolframAlph closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@WolframAlph
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.