GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-127750: Fix functools.singledispatchmethod() by eendebakpt · Pull Request #130029 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Feb 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In this PR we revert the changes from #107148 (but keep the added tests). This addresses

  • Collisions between different objects with equal __hash__/__eq__
  • Keeping object instances alive

For 3.14+ there are open PRs to address the same issues without the performance regression, but for 3.13 it seems safer to revert the changes (#127750 (comment))

@serhiy-storchaka @Yhg1s

  • Issue: Regression in Django with singledispatchmethod on models #127750

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eendebakpt
Revert pythongh-107148
7606147
@eendebakpt
eendebakpt requested a review from rhettinger as a code owner February 12, 2025 09:45
@bedevere-app bedevere-app Bot added the awaiting review label Feb 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2025
Regression in Django with singledispatchmethod on models #127750
Closed
@eendebakpt eendebakpt added the 3.13 only security fixes label Feb 12, 2025
@eendebakpt eendebakpt changed the title gh-127750: Fix singledispatchmethod [3.13] gh-127750: Fix singledispatchmethod Feb 12, 2025
blurb-it Bot and others added 2 commits February 12, 2025 09:48
@blurb-it
📜🤖 Added by blurb_it.
b3064f1
@eendebakpt
Merge branch '3.13' into revert_gh_107148
77935ab
@eendebakpt eendebakpt changed the title [3.13] gh-127750: Fix singledispatchmethod [3.13] gh-127750: Fix functools.singledispatchmethod() Feb 12, 2025
@ZeroIntensity ZeroIntensity removed the 3.13 only security fixes label Feb 12, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Feb 14, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 14, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Feb 17, 2025
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 8f33c7a into python:3.13 Feb 17, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eendebakpt @serhiy-storchaka @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.