GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c by WolframAlph · Pull Request #130032 · python/cpython

Conversation

@WolframAlph

@WolframAlph WolframAlph commented Feb 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Move const folding to the peephole optimizer #126835

cc @Eclips4 @tomasr8

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
WolframAlph added 4 commits February 12, 2025 13:14
@WolframAlph
move compare/iter folding to CFG
1ef3754
@WolframAlph
remove ast tests
ed4820b
@WolframAlph
add tests
88a7797
@WolframAlph
adjust test compile
4ee4054
@WolframAlph
WolframAlph requested review from Eclips4, iritkatriel, isidentical and markshannon as code owners February 12, 2025 12:22
@bedevere-app bedevere-app Bot added the awaiting review label Feb 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2025
Move const folding to the peephole optimizer #126835
Open
@WolframAlph
remove test code
deb62c0
WolframAlph
WolframAlph commented Feb 12, 2025
View reviewed changes
Comment thread Lib/test/test_compile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@WolframAlph
check frozenset return
b3a2aeb
iritkatriel
iritkatriel reviewed Feb 12, 2025
View reviewed changes
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@WolframAlph
address review
7b3e480
@WolframAlph
WolframAlph requested a review from iritkatriel February 12, 2025 15:09
@Eclips4 Eclips4 added the skip news label Feb 12, 2025
Eclips4
Eclips4 approved these changes Feb 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 12, 2025
iritkatriel
iritkatriel reviewed Feb 12, 2025
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@WolframAlph
address review
eb3abc2
@WolframAlph
WolframAlph requested a review from iritkatriel February 13, 2025 08:33
iritkatriel
iritkatriel approved these changes Feb 13, 2025
View reviewed changes
@iritkatriel iritkatriel changed the title gh-126835: Move literal list & set optimization in for iter & contains test to CFG. gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c Feb 13, 2025
@iritkatriel
Merge branch 'main' into compare-cfg
a0a378d
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 13, 2025
@bedevere-bot

bedevere-bot commented Feb 13, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit eb3abc2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 13, 2025
@iritkatriel
iritkatriel merged commit 140e69c into python:main Feb 13, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 13, 2025
@bedevere-bot

bedevere-bot commented Feb 13, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO 3.x has failed when building commit 140e69c.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/336/builds/6345) and take a look at the build logs.
  4. Check if the failure is related to this commit (140e69c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/336/builds/6345

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes
@iritkatriel iritkatriel iritkatriel approved these changes
@isidentical isidentical Awaiting requested review from isidentical
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@WolframAlph @bedevere-bot @iritkatriel @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.