GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-129641: Docs GHA build: use upload-artifact@v4 (GH-129642) by encukou · Pull Request #130114 · python/cpython

Conversation

@encukou

@encukou encukou commented Feb 14, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Backported from commit 7b0351c

Includes a typo fix to trigger a docs build in CI
(backported from GH-128077, commit 5a584c8)

  • Issue: 3.10: GHA Docs builds of PRs fail because they use removed actions/upload-artifact: v3 #129641

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
encukou and others added 2 commits February 14, 2025 15:08
@encukou
[3.9] pythongh-129641: Switch Docs GHA build to actions/upload-artifa…
e3b25cd 
…ct@v4 (pythonGH-129642)

Add options for backwards compatibility, from the docs at:
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
@shallow-beach @encukou
Python Tutorial typo fix (python#128077)
f3b7794 
Backported form commit: 5a584c8

This is a trivial change meant to trigger a Docs build.
@bedevere-app bedevere-app Bot added the skip news label Feb 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 14, 2025
[3.10] gh-129641: Docs GHA build: use upload-artifact@v4 & Python 3.12 #129642
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 14, 2025
3.10: GHA Docs builds of PRs fail because they use removed actions/upload-artifact: v3 #129641
Closed
@encukou

encukou commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

See #129509 for the RtD failure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland approved these changes Feb 17, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk
hugovk approved these changes Feb 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 18, 2025
@hugovk
hugovk merged commit fe6c43e into python:3.9 Feb 18, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 18, 2025
@encukou
encukou deleted the 3.9-backport-7b0351c branch February 18, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @hugovk @StanFromIreland @shallow-beach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.