GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130273: Fix incorrectly colored error locations when wide unicode characters exists by HarryLHW · Pull Request #130277 · python/cpython

Conversation

@HarryLHW

@HarryLHW HarryLHW commented Feb 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Traceback colors are shifted when the line contains wide unicode characters #130273

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@HarryLHW
Fix incorrectly colored error locations when wide unicode characters …
efd61e8 
…exist
@bedevere-app bedevere-app Bot mentioned this pull request Feb 18, 2025
Traceback colors are shifted when the line contains wide unicode characters #130273
Closed
grayjk
grayjk reviewed Feb 18, 2025
View reviewed changes
Comment thread Lib/traceback.py
for i in range(start, len(line)):
if width <= 0:
return i, line[start:i]
width -= 2 if east_asian_width(line[i]) in _WIDE_CHAR_SPECIFIERS else 1

@grayjk grayjk Feb 18, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this correctly handle zero-width characters? e.g. the '\u0301' from 'cafe\u0301'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@HarryLHW HarryLHW Feb 19, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
However, _display_width() does not correctly handle zero-width characters for carets positions either.

>>> café = 1/0
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    café = 1/0
            ~^~
ZeroDivisionError: division by zero
>>>

They can be fixed in the same way. I wonder how I can find all the zero-width characters.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@grayjk grayjk Feb 19, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are many zero-width characters: https://wcwidth.readthedocs.io/en/latest/specs.html#width-of-0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
HarryLHW reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@HarryLHW HarryLHW Feb 19, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how wcwidth implements wcswidth() and wcwidth(): https://wcwidth.readthedocs.io/en/latest/_modules/wcwidth/wcwidth.html#wcswidth
Maybe it is too complicated for our traceback? Could we have a simple way that can handle most of the cases?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv ambv closed this Apr 7, 2026
@ambv

ambv commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Going with #142529 instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@grayjk grayjk grayjk left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@HarryLHW @ambv @grayjk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.