GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-130163: Fix usage of borrow references from _PySys_GetAttr by sergey-miryanov · Pull Request #130282 · python/cpython Conversation
|
| Repro | Tests | Raised exception | |
|---|---|---|---|
_pickle.c/whichmodule |
No | No | Don't keep |
_threadmodule.c/thread_excepthook |
No | No | Keep |
faulthandler.c/faulthandler_get_fileno |
Yes | Yes | Don't keep |
bltinmodule.c/builtin_print_impl |
Yes | Yes | Don't keep |
bltinmodule.c/builtin_input_impl |
Yes | Yes | Don't keep |
errors.c/write_unraisable_exc |
No | No | Keep |
errors.c/format_unraisable_v |
Yes | Yes | Keep |
_warnings.c/show_warning |
Yes | Yes | Don't keep |
intrinsics.c/print_expr |
No | No | Don't keep |
pylifecycle.c/flush_std_files |
Yes/No | Yes/No | Don't keep |
pythonrun.c/_PyRun_InteractiveLoopObject |
No | No | Don't keep |
pythonrun.c/pyrun_one_parse_ast |
No | No | Don't keep |
pythonrun.c/_Py_HandleSystemExitAndKeyboardInterrupt |
No | No | Don't keep |
pythonrun.c/_PyErr_PrintEx |
Yes | Yes | Don't keep |
pythonrun.c/PyErr_Display |
No | No | Don't keep |
pythonrun.c/flush_io_stream |
No | No | Don't keep |
sysmodule.c/sys_displayhook |
Maybe | No | Don't keep |
sysmodule.c/get_warnoptions |
No | No | Don't keep |
sysmodule.c/PySys_ResetWarnOptions |
No | No | Don't keep |
sysmodule.c/PySys_HasWarnOptions |
No | No | Don't keep |
sysmodule.c/_PySys_AddXOptionWithError |
No | No | Don't keep |
sysmodule.c/PySys_SetArgvEx |
No | No | Don't keep |
sysmodule.c/sys_write |
No | No | Don't keep |
sysmodule.c/sys_format |
No | No | Don't keep |
traceback.c/_Py_FindSourceFile |
No | No | Don't keep |
- I can get a "segfault" error when I use
sys_displayhook, but not where it's used. - For
sys_write,sys_format- I have checked all the places where they called, and most of the locations are safe. However, a few places use%sspecifier, in such places it is very tricky to getsegfault. get_warnoptions,PySys_ResetWarnOptions,_PySys_AddXOptionWithError- are deprecated, but it is a very tricky to getsegfaulttoo.flush_io_stream,PyErr_Display,pyrun_one_parse_ast,print_expr,write_unraisable_exc,thread_excepthook- very tight - They use a borrowed reference right after getting. It might be possible to reproduce it under heavy contention, but I wasn't able to do so._PyRun_InteractiveLoopObjectonly checks presence ofps1andps2.flush_std_filesused from_Py_Finalizeand fromfatal_error. For_Py_FinalizeI can repro, forfatal_error- no.whichmodule,_Py_FindSourceFileiterate borrowed reference, but I wasn't able to reproducesegfault.- Keep or not before raised exception - in the most places
_PySys_GetAttrcalled without an exception set.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
- also add checks of exit code
Contributor
Author
|
Close in favor #130503 |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
No reviewsUh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
tests
Tests in the Lib/test dir
Projects
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.