GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] Convert change detection to a Python script (GH-129627) by hugovk · Pull Request #130370 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Feb 20, 2025

Copy link
Copy Markdown
Member

(cherry picked from commit 7d9a22f)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner @hugovk @webknjaz
[3.12] Convert change detection to a Python script (pythonGH-129627)
0ce2b94 
(cherry picked from commit 7d9a22f)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@bedevere-app bedevere-app Bot added skip issue skip news labels Feb 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 20, 2025
Convert change detection to a Python script #129627
Merged
AA-Turner
AA-Turner reviewed Feb 20, 2025
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
}}
${{
!fromJSON(needs.check_source.outputs.run_hypothesis)
!fromJSON(needs.build-context.outputs.run_hypothesis)

@AA-Turner AA-Turner Feb 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is here I think. Note difference from 7d9a22f.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Feb 21, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, how's e17a76b (#130370)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk
Fix test_hypothesis
e17a76b
AA-Turner
AA-Turner approved these changes Feb 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Feb 21, 2025
@hugovk
hugovk marked this pull request as ready for review February 21, 2025 15:18
@hugovk
hugovk requested review from 1st1 and ezio-melotti as code owners February 21, 2025 15:18
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels Feb 21, 2025
@hugovk
hugovk enabled auto-merge (squash) February 21, 2025 15:18
@hugovk
hugovk merged commit 91e5e24 into python:3.12 Feb 21, 2025
@hugovk
hugovk deleted the backport-7d9a22f-3.12 branch February 21, 2025 15:18
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.