GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130384: Skip a test_getallocatedblocks test pre-condition on iOS. by freakboy3742 · Pull Request #130385 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Feb 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#130007 introduced a change to the handling of C stack limits, which caused the test_sys.SysModuleTest.get_allocated_blocks() test to start failing in CI on iOS.

This PR skips the specific test precondition that is causing the test failure when running on iOS. This is based on the fact that the assertion appears to be a precondition that has some other "escape clauses" (like running on a free threading build), and is documented as asserting something that is "unlikely to happen in a normal test run". I don't know why iOS is causing the "unlikely" condition to happen reliably in CI... but it apparently does.

I'll be honest - I don't feel good about this PR. However, I don't have anywhere near enough knowledge or experience to understand what interaction of memory allocation and garbage collection would be causing this to only occur on iOS, and only in CI. I can't reproduce the problem locally, and it doesn't appear to be causing any larger issues with operation on iOS.

  • Issue: test_sys.SysModuleTest.get_allocated_blocks test precondition intermittently fails on iOS #130384

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Skip a test_getallocatedblocks test pre-condition on iOS.
9b311b3
@freakboy3742 freakboy3742 added skip issue skip news labels Feb 20, 2025
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Feb 20, 2025
@freakboy3742

freakboy3742 commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 20, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9b311b3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130385%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 removed the skip issue label Feb 21, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 21, 2025
test_sys.SysModuleTest.get_allocated_blocks test precondition intermittently fails on iOS #130384
Closed
@freakboy3742
freakboy3742 requested a review from markshannon February 21, 2025 00:22
@markshannon

markshannon commented Feb 24, 2025

Copy link
Copy Markdown
Member

The pre-condition is wrong #130384 (comment), so I think it would be fine to remove the precondition altogether.
But let's merge this for now, and restore the test when we fix sys.getallocatedblocks()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 8a76eb8 into python:main Feb 24, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 24, 2025
@freakboy3742
freakboy3742 deleted the skip-allocated-blocks-precondition branch February 24, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@freakboy3742 @bedevere-bot @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.