GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] Add test checking value of a TypedDict's __total__ attribute when there is an assignment in the class body. (GH-130460) by miss-islington · Pull Request #130462 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

In relation to GH-109544 which changed this behavior.
(cherry picked from commit d8ce092)

Co-authored-by: Daraan [email protected]
Signed-off-by: Daniel Sperber [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Daraan @miss-islington
Add test checking value of a TypedDict's __total__ attribute when the…
78b0da8
…re is an assignment in the class body. (pythonGH-130460)

In relation to pythonGH-109544 which changed this behavior.
(cherry picked from commit d8ce092)

Co-authored-by: Daraan <[email protected]>
Signed-off-by: Daniel Sperber <[email protected]>
@miss-islington
miss-islington requested review from AlexWaygood and JelleZijlstra as code owners February 22, 2025 17:34
@bedevere-app bedevere-app Bot added skip issue skip news labels Feb 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 22, 2025
Add test checking value of a TypedDict's __total__ attribute when there is an assignment in the class body. #130460
Merged
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Feb 22, 2025
JelleZijlstra
JelleZijlstra approved these changes Feb 22, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 22, 2025
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) February 22, 2025 17:35
@JelleZijlstra
JelleZijlstra merged commit 6abec03 into python:3.13 Feb 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 22, 2025
@miss-islington
miss-islington deleted the backport-d8ce092-3.13 branch January 2, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @JelleZijlstra @Daraan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.