GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-130396: Include stack margin for debug windows builds by markshannon · Pull Request #130554 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Feb 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This might only be necessary on Windows debug free-threading builds, but it is simpler and harmless to do this for any Windows debug build.

  • Issue: Implement stack overflow protection for linux based on actual stack depth #130396

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Include stack margin for debug windows builds
0305b4c
@markshannon
markshannon requested a review from ericsnowcurrently as a code owner February 25, 2025 18:15
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 25, 2025
@markshannon markshannon changed the title GH-130552: Include stack margin for debug windows builds GH-130396: Include stack margin for debug windows builds Feb 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 25, 2025
Implement stack overflow protection for linux based on actual stack depth #130396
Closed
@markshannon markshannon added the skip news label Feb 25, 2025
brandtbucher
brandtbucher approved these changes Feb 25, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Should we run the buildbot it broke?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 25, 2025
@markshannon

markshannon commented Feb 25, 2025

Copy link
Copy Markdown
Member Author

Actually, its a CI job: https://github.com/python/cpython/actions/runs/13527121766/job/37803109505?pr=130550
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 2dad1e0 into python:main Feb 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 25, 2025
@markshannon markshannon mentioned this pull request Feb 25, 2025
GH-130396: Increase trashcan overhead #130552
Merged
@markshannon
markshannon deleted the more-stack-windows-ft branch February 27, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.