GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-130163: Fix crashes related to PySys_GetObject() (GH-130503) (GH-130556) by serhiy-storchaka · Pull Request #130576 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowed reference, has been replaced by using one of the following functions, which return a strong reference and distinguish a missing attribute from an error: _PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(), _PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString(). (cherry picked from commit 0ef4ffe) (cherry picked from commit 7c1b76f)

  • Issue: Crash when concurrently writing with print and concurrently modifying sys.stdout #130163

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.12] pythongh-130163: Fix crashes related to PySys_GetObject() (pyt…
4cf5fc4 
…honGH-130503) (pythonGH-130556)

The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowed
reference, has been replaced by using one of the following functions, which
return a strong reference and distinguish a missing attribute from an error:
_PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(),
_PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString().
(cherry picked from commit 0ef4ffe)
(cherry picked from commit 7c1b76f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot added the topic-free-threading label Feb 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2025
[3.13] gh-130163: Fix crashes related to PySys_GetObject() (GH-130503) #130556
Merged
@bedevere-app bedevere-app Bot added the type-crash A hard crash of the interpreter, possibly with a core dump label Feb 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2025
Crash when concurrently writing with print and concurrently modifying sys.stdout #130163
Closed
serhiy-storchaka added 2 commits February 26, 2025 14:00
@serhiy-storchaka
[3.13] pythongh-130163: Fix a leak in _pickle.c after backporting (py…
452420f 
…thonGH-130568)

(cherry picked from commit 2ab7e11)
@serhiy-storchaka
Other fixes and cleanup.
29b10db
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review February 26, 2025 15:19
@serhiy-storchaka
serhiy-storchaka requested review from brettcannon, encukou, ericsnowcurrently, iritkatriel, ncoghlan and warsaw as code owners February 26, 2025 15:19
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 26, 2025
@serhiy-storchaka
serhiy-storchaka merged commit 89a79fc into python:3.12 Feb 26, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 26, 2025
@serhiy-storchaka
serhiy-storchaka deleted the backport-7c1b76f-3.12 branch February 26, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-free-threading type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.