GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90916: Add helper function to dis.Instruction and use it to reduce churn in test_dis by markshannon · Pull Request #130643 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Feb 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replaces

   Instruction(opname = NAME, opcode=NUMBER, ...

with

  make_inst(opanme=NAME, ...

to reduce the pointless churn every time instructions get renumbered.

  • Issue: test_dis should test the dis module, not everything else #90916

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 2 commits February 27, 2025 16:00
@markshannon
Add helper function to dis.Instruction and use it to reduce churn in …
0e28896 
…test_dis
@markshannon
Reduce line length and restore doc for opcode
742ec36
@bedevere-app bedevere-app Bot mentioned this pull request Feb 27, 2025
test_dis should test the dis module, not everything else #90916
Open
@markshannon markshannon added the skip news label Feb 27, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 27, 2025
@markshannon markshannon mentioned this pull request Feb 28, 2025
gh-130574: renumber RESUME opcode from 149 to 128 #130685
Merged
iritkatriel
iritkatriel approved these changes Mar 4, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 4, 2025
@markshannon
markshannon merged commit 885c3d1 into python:main Mar 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.