GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-129726: Break `gzip.GzipFile` reference loop (GH-130055) by miss-islington · Pull Request #130670 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

A reference loop was resulting in the fileobj held by the GzipFile
being closed before the GzipFile.

The issue started with gh-89550 in 3.12, but was hidden in most cases
until 3.13 when gh-62948 made it more visible.
(cherry picked from commit 7f39137)

Co-authored-by: Cody Maloney [email protected]

  • Issue: gzip raising exception when closing with buffer backed by BytesIO #129726

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cmaloney @miss-islington
pythongh-129726: Break gzip.GzipFile reference loop (pythonGH-130055)
ec34427
A reference loop was resulting in the `fileobj` held by the `GzipFile`
being closed before the `GzipFile`.

The issue started with pythongh-89550 in 3.12, but was hidden in most cases
until 3.13 when pythongh-62948 made it more visible.
(cherry picked from commit 7f39137)

Co-authored-by: Cody Maloney <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2025
gh-129726: Break gzip.GzipFile reference loop #130055
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Feb 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2025
gzip raising exception when closing with buffer backed by BytesIO #129726
Closed
@vstinner
vstinner enabled auto-merge (squash) February 28, 2025 08:10
@vstinner
vstinner merged commit 500ea3b into python:3.12 Feb 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 28, 2025
@cmaloney cmaloney mentioned this pull request Mar 7, 2025
gh-129640: Add tests for reference cycle in gzip.GzipFile #130916
Closed
@miss-islington
miss-islington deleted the backport-7f39137-3.12 branch January 2, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @cmaloney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.