GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36475: Make PyThread_exit_thread with _Py_NO_RETURN by vstinner · Pull Request #13068 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 2, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue36475

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-36475: Make PyThread_exit_thread with _Py_NO_RETURN
0968e54
@vstinner vstinner added the skip news label May 2, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 2, 2019
@bedevere-bot bedevere-bot added the awaiting core review label May 2, 2019
@vstinner vstinner mentioned this pull request May 2, 2019
bpo-36475: Finalize PyEval_AcquireLock() and PyEval_AcquireThread() properly #12667
Merged
@vstinner
vstinner requested a review from ncoghlan May 2, 2019 19:36
@vstinner

vstinner commented May 2, 2019

Copy link
Copy Markdown
Member Author

@ncoghlan @nanjekyejoannah: Would you mind to review this change?

It's a follow-up of PR #12667.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ncoghlan
ncoghlan approved these changes May 3, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 3, 2019
@vstinner
vstinner merged commit c664b34 into python:master May 4, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label May 4, 2019
@vstinner
vstinner deleted the noreturn branch May 4, 2019 15:48
@vstinner

vstinner commented May 4, 2019

Copy link
Copy Markdown
Member Author

Thanks for the review Nick!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @ncoghlan @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.