GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: Fix function signatures of unicodeiter by vstinner · Pull Request #130684 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111178: Fix function signatures of unicodeiter
e03dc04
@vstinner vstinner added the skip news label Feb 28, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
picnixz
picnixz reviewed Feb 28, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still UBSan failures, e.g., unicodeiter_len and unicodeiter_reduce. Could you change them as well? TiA.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Change more signatures
fb627f4
@vstinner

vstinner commented Feb 28, 2025

Copy link
Copy Markdown
Member Author

There are still UBSan failures, e.g., unicodeiter_len and unicodeiter_reduce. Could you change them as well? TiA.

Oh, I missed these functions. I updated them as well. Please take another look.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit ed8675c into python:main Mar 4, 2025
@vstinner
vstinner deleted the ubsan_unicodeiter branch March 4, 2025 09:33
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 4, 2025
@picnixz

picnixz commented Mar 4, 2025

Copy link
Copy Markdown
Member

Please take another look

I forgot to have a look... sorry :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Mar 4, 2025

Copy link
Copy Markdown
Member

When I forget, please don't hesistate to request a review or ping me on Discord!
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.