GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-128942: make `array` module thread safe (#128943)" by colesbury · Pull Request #130707 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Feb 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The change regressed performance on scimark benchmarks from the pyperformance benchmark suite.

This reverts commit 8ba0d7b.

  • Issue: Python array module is not free-thread safe. #128942

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
Revert "pythongh-128942: make array module thread safe (python#128943…
805704e 
…)"

The change regressed performance on scimark benchmarks from the
pyperformance benchmark suite.

This reverts commit 8ba0d7b.
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2025
Python array module is not free-thread safe. #128942
Open
@colesbury
colesbury marked this pull request as ready for review February 28, 2025 20:38
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 28, 2025
@colesbury
colesbury requested review from kumaraditya303 and mpage February 28, 2025 20:55
@colesbury

colesbury commented Feb 28, 2025

Copy link
Copy Markdown
Contributor Author

cc @tom-pytel
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mpage
mpage approved these changes Feb 28, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 28, 2025
@colesbury
colesbury merged commit 75f38af into python:main Feb 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2025
@colesbury
colesbury deleted the gh-128942-revert branch February 28, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @mpage
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.