GeezerVison is showing github.com — GH-127381: pathlib ABCs: remove `case_sensitive` argument by barneygale · Pull Request #131024 · python/cpython
Conversation
barneygale
commented
Mar 9, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Remove the case_sensitive argument from _JoinablePath.full_match() and _ReadablePath.glob(). Using a non-native case sensitivity forces the use of "case-pedantic" globbing, where we iterdir() even for non-wildcard pattern segments. But it's hard to know when to enable this mode, as case-sensitivity can vary by directory, so _PathParser.normcase() doesn't always give the full picture. The Path.glob() implementation is forced to make an educated guess, but we can avoid the issue in the ABCs by dropping the case_sensitive argument.
(I probably shouldn't have added this argument in Path.glob() in the first place!)
Also drop support for _ReadablePath.glob(recurse_symlinks=False), which makes recursive globbing much slower.
No change to the public pathlib classes.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Remove the *case_sensitive* argument from `_JoinablePath.full_match()` and
`_ReadablePath.glob()`. Using a non-native case sensitivity forces the use
of "case-pedantic" globbing, where we `iterdir()` even for non-wildcard
pattern segments. But it's hard to know when to enable this mode, as
case-sensitivity can vary by directory, so `_PathParser.normcase()` doesn't
always give the full picture. The `Path.glob()` implementation is forced to
make an educated guess, but we can avoid the issue in the ABCs by dropping
the *case_sensitive* argument.
(I probably shouldn't have added these arguments in `PurePath` and `Path`
in the first place!)
Also drop support for `_ReadablePath.glob(recurse_symlinks=False)`, which
makes recursive globbing much slower.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.