GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130664: specify how thousands separators are used with 0-padding by skirpichev · Pull Request #131030 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Mar 10, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Undocumented handling of thousands separator for floats and differences wrt Decimal #130664

📚 Documentation preview 📚: https://cpython-previews--131030.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-130664: specify how thousands separators are used with 0-pad…
d26c426 
…ding
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 10, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs Mar 10, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2025
Undocumented handling of thousands separator for floats and differences wrt Decimal #130664
Open
effigies
effigies reviewed Mar 10, 2025
View reviewed changes
Comment thread Doc/library/string.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev and others added 3 commits March 11, 2025 02:24
@skirpichev @effigies
Update Doc/library/string.rst
3304ed2 
Co-authored-by: Chris Markiewicz <[email protected]>
@skirpichev
Merge branch 'master' into fill-docs/130664
4fbd177
@skirpichev
thousands separators -> digit group separators
6931a67
@skirpichev skirpichev added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Apr 6, 2025
@skirpichev
skirpichev requested a review from effigies April 6, 2025 11:28
effigies
effigies approved these changes Apr 6, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Apr 6, 2025
StanFromIreland
StanFromIreland reviewed Apr 6, 2025
View reviewed changes
Comment thread Doc/library/string.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev @StanFromIreland
Update Doc/library/string.rst
71dcf25 
Co-authored-by: Stan Ulbrych <[email protected]>
@skirpichev skirpichev removed the needs backport to 3.12 only security fixes label Apr 8, 2025
@skirpichev
skirpichev requested a review from StanFromIreland April 8, 2025 21:57
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@skirpichev
skirpichev requested a review from serhiy-storchaka July 3, 2025 08:01
@skirpichev
skirpichev requested a review from picnixz July 19, 2025 05:37
picnixz
picnixz reviewed Aug 2, 2025
View reviewed changes
Comment thread Doc/library/string.rst Outdated
(``'0'``) character enables sign-aware zero-padding for numeric types,
excluding :class:`complex`. This is equivalent to a *fill* character of
``'0'`` with an *alignment* type of ``'='``.
``'0'`` with an *alignment* type of ``'='``. If digit group separators of the

@picnixz picnixz Aug 2, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that "digit group separator" is mentioned here while we only mention it in the "grouping option" paragraph below. Maybe we should mention it at that place or mention here that this will be introduced below?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@serhiy-storchaka serhiy-storchaka Aug 2, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the different parts of the format are interconnected, there may be references to options described in details below.

But I think that we should unify wording and avoid repetition of what specifies the grouping option. "If the grouping option for the integral part is used, a digit group separator is also inserted between leading zeros."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skirpichev skirpichev Oct 10, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka, I think that remark was addressed. Is there anything left?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
skirpichev added 2 commits August 2, 2025 16:28
@skirpichev
Merge branch 'master' into fill-docs/130664
751d559
@skirpichev
address review: don't repeat description of digit group separator
4aae176
@skirpichev
skirpichev requested a review from picnixz August 2, 2025 13:35
@skirpichev

skirpichev commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

CC @ericvsmith
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 22, 2026
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label May 30, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 31, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 2, 2026
@skirpichev skirpichev closed this Sep 3, 2026
@skirpichev
skirpichev deleted the fill-docs/130664 branch September 3, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@picnixz picnixz Awaiting requested review from picnixz
1 more reviewer
@effigies effigies effigies approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@skirpichev @effigies @serhiy-storchaka @picnixz @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.