GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128002: add test_asyncio.test_free_threading to tsan tests by kumaraditya303 · Pull Request #131106 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Mar 11, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Audit asyncio thread safety  #128002

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
add test_asyncio.test_free_threading to tsan CI
e29812b
@kumaraditya303 kumaraditya303 added topic-asyncio skip news topic-free-threading labels Mar 11, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 11, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 11, 2025
Audit asyncio thread safety #128002
Closed
9 tasks done
@kumaraditya303 kumaraditya303 changed the title gh-128002: add test_asyncio.test_free_threading to tsan CI gh-128002: add test_asyncio.test_free_threading to tsan tests Mar 11, 2025
@kumaraditya303
kumaraditya303 requested a review from colesbury March 11, 2025 17:56
colesbury
colesbury approved these changes Mar 11, 2025
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have time to look at the other TSAN reported races in test_asyncio?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 11, 2025
@kumaraditya303

kumaraditya303 commented Mar 11, 2025

Copy link
Copy Markdown
Contributor Author

Do you have time to look at the other TSAN reported races in test_asyncio?

What are the other TSAN races?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury

colesbury commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

If you run the test_asyncio tests under TSAN you'll see a bunch of races. Here are the ones I've seen when running it:

https://gist.github.com/colesbury/210e1e1c60d38dbfd92e5226d7848b38

There are also a few additional ones when run with the GIL enabled, because it doesn't use some of the atomic operations that we use in the free threading build.

I wouldn't worry about the frame_clear race for now, but I think the other ones, including the file descriptor races can be fixed.
kumaraditya303 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Mar 11, 2025

Copy link
Copy Markdown
Contributor Author

If you run the test_asyncio tests under TSAN you'll see a bunch of races. Here are the ones I've seen when running it:

https://gist.github.com/colesbury/210e1e1c60d38dbfd92e5226d7848b38

There are also a few additional ones when run with the GIL enabled, because it doesn't use some of the atomic operations that we use in the free threading build.

Thanks! I will look into it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 merged commit 2407049 into python:main Mar 11, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 11, 2025
@kumaraditya303
kumaraditya303 deleted the asyncio branch March 11, 2025 20:03
@colesbury

colesbury commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

To follow up on my previous comment: I think that fixing the file descriptor races might involve changing the test code to avoid concurrent close() operations with operations that use the sockets, but I'm not entirely sure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-asyncio topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kumaraditya303 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.