GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130931: Add pycore_interpframe.h internal header by vstinner · Pull Request #131249 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 14, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move _PyInterpreterFrame and associated functions to a new pycore_interpframe.h header.

  • Issue: Cython cannot use "pycore_frame.h" in Py3.14a4 #130931

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Mar 14, 2025
@vstinner
vstinner requested a review from markshannon as a code owner March 14, 2025 15:29
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2025
Cython cannot use "pycore_frame.h" in Py3.14a4 #130931
Open
@vstinner vstinner mentioned this pull request Mar 18, 2025
gh-130931: Add pycore_typedefs.h internal header #131396
Merged
@vstinner
vstinner marked this pull request as draft March 18, 2025 09:51
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 18, 2025
@vstinner
vstinner force-pushed the pycore_interpframe branch 2 times, most recently from a4816c3 to b2db8ea Compare March 18, 2025 09:54
@vstinner

vstinner commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

This PR now needs #131396. I rebased this PR on top of PR gh-131396 and marked it as a draft to wait until PR gh-131396 is merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner force-pushed the pycore_interpframe branch 2 times, most recently from 8660a4a to 8161a9b Compare March 19, 2025 15:14
@vstinner
pythongh-130931: Add pycore_interpframe.h internal header
0d60edb 
Move _PyInterpreterFrame and associated functions
to a new pycore_interpframe.h header.
@vstinner
vstinner force-pushed the pycore_interpframe branch from 8161a9b to 0d60edb Compare March 19, 2025 15:15
@vstinner
Fix gc_free_threading.c
0b7585f
@vstinner
vstinner marked this pull request as ready for review March 19, 2025 15:45
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 19, 2025
@vstinner

vstinner commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

@markshannon: Are you ok with this trade-off to unblock Cython for now?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 5c44d7d into python:main Mar 19, 2025
@vstinner
vstinner deleted the pycore_interpframe branch March 19, 2025 17:17
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 19, 2025
@vstinner

vstinner commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

@markshannon: Are you ok with this trade-off to unblock Cython for now?

See @markshannon's comment on the issue: #130931 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 19, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 5c44d7d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/10633) and take a look at the build logs.
  4. Check if the failure is related to this commit (5c44d7d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/10633

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 34, done.        
remote: Counting objects:   2% (1/34)        
remote: Counting objects:   5% (2/34)        
remote: Counting objects:   8% (3/34)        
remote: Counting objects:  11% (4/34)        
remote: Counting objects:  14% (5/34)        
remote: Counting objects:  17% (6/34)        
remote: Counting objects:  20% (7/34)        
remote: Counting objects:  23% (8/34)        
remote: Counting objects:  26% (9/34)        
remote: Counting objects:  29% (10/34)        
remote: Counting objects:  32% (11/34)        
remote: Counting objects:  35% (12/34)        
remote: Counting objects:  38% (13/34)        
remote: Counting objects:  41% (14/34)        
remote: Counting objects:  44% (15/34)        
remote: Counting objects:  47% (16/34)        
remote: Counting objects:  50% (17/34)        
remote: Counting objects:  52% (18/34)        
remote: Counting objects:  55% (19/34)        
remote: Counting objects:  58% (20/34)        
remote: Counting objects:  61% (21/34)        
remote: Counting objects:  64% (22/34)        
remote: Counting objects:  67% (23/34)        
remote: Counting objects:  70% (24/34)        
remote: Counting objects:  73% (25/34)        
remote: Counting objects:  76% (26/34)        
remote: Counting objects:  79% (27/34)        
remote: Counting objects:  82% (28/34)        
remote: Counting objects:  85% (29/34)        
remote: Counting objects:  88% (30/34)        
remote: Counting objects:  91% (31/34)        
remote: Counting objects:  94% (32/34)        
remote: Counting objects:  97% (33/34)        
remote: Counting objects: 100% (34/34)        
remote: Counting objects: 100% (34/34), done.        
remote: Compressing objects:   6% (1/15)        
remote: Compressing objects:  13% (2/15)        
remote: Compressing objects:  20% (3/15)        
remote: Compressing objects:  26% (4/15)        
remote: Compressing objects:  33% (5/15)        
remote: Compressing objects:  40% (6/15)        
remote: Compressing objects:  46% (7/15)        
remote: Compressing objects:  53% (8/15)        
remote: Compressing objects:  60% (9/15)        
remote: Compressing objects:  66% (10/15)        
remote: Compressing objects:  73% (11/15)        
remote: Compressing objects:  80% (12/15)        
remote: Compressing objects:  86% (13/15)        
remote: Compressing objects:  93% (14/15)        
remote: Compressing objects: 100% (15/15)        
remote: Compressing objects: 100% (15/15), done.        
remote: Total 18 (delta 16), reused 4 (delta 3), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '5c44d7d99c470b4270b2f0e4841cf5a7f2499e15'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 5c44d7d99c4 gh-130931: Add pycore_interpframe.h internal header (#131249)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:3213: clean-retain-profile] Error 1 (ignored)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury

colesbury commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Would you please add this to PYTHON_HEADERS in Makefile.pre.in?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 21, 2025

Copy link
Copy Markdown
Member Author

Would you please add this to PYTHON_HEADERS in Makefile.pre.in?

Oops, I was sure that I did! I wrote #131545 to add it to PYTHON_HEADERS.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @bedevere-bot @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.