GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36675: Fix doctest directives comments disappear bug by tczorro · Pull Request #13125 · python/cpython

Conversation

@tczorro

@tczorro tczorro commented May 6, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
  1. Change :: detective to : in order to fix the doc bugs
    ref:https://bugs.python.org/issue36675

https://bugs.python.org/issue36675

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tczorro
Fix doctest directives comments disappear bug
9d1a092 
1. Change :: detective to : in order to fix the doc bugs
ref:https://bugs.python.org/issue36675
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 6, 2019
@the-knights-who-say-ni

the-knights-who-say-ni commented May 6, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 6, 2019
@matrixise
matrixise requested a review from JulienPalard May 6, 2019 18:47
@tczorro
Add blurb entry for this fix.
1ba5448
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 6, 2019
auvipy
auvipy approved these changes Jun 1, 2019
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 1, 2019
@tczorro

tczorro commented Aug 25, 2019

Copy link
Copy Markdown
Author

@JulienPalard I am sorry to bother you, but if you have some spare time, could you please review this little patch for doc fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard

JulienPalard commented Sep 11, 2019

Copy link
Copy Markdown
Member

I tried a local build and your patch do not fix the issue. I'm investigating, I just found a trim_doctest_flags variable in tools/extensions/pyspecific.py, probably a good lead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard

JulienPalard commented Sep 12, 2019

Copy link
Copy Markdown
Member

I opened an issue here: sphinx-doc/sphinx#6698 and commented on b.p.o.

As this PR proposes a fix that does not fix the issue (the flags are still trimmed), I'll just close this one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard JulienPalard closed this Sep 12, 2019
@stevendaprano stevendaprano mentioned this pull request May 5, 2022
Doctest directives and comments missing from code samples #80856
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard Awaiting requested review from JulienPalard
1 more reviewer
@auvipy auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tczorro @the-knights-who-say-ni @JulienPalard @auvipy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.