GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131178: Add tests for `pickle` command-line interface by donbarbos · Pull Request #131275 · python/cpython

Conversation

@donbarbos

@donbarbos donbarbos commented Mar 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add tests for command-line interface #131178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@donbarbos
Add tests for pickle command-line interface
fbc695a
@bedevere-app bedevere-app Bot added the awaiting review label Mar 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 15, 2025
Add tests for command-line interface #131178
Open
7 of 9 tasks
@donbarbos

donbarbos commented Mar 15, 2025

Copy link
Copy Markdown
Contributor Author

Tests fail because sets {} don't preserve the order of elements.
Seems to be expected behavior for sets so I'll remove them from the tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
donbarbos added 4 commits March 15, 2025 13:03
@donbarbos
Use string instead of set
8f720ae
@donbarbos
remove second io import
2cf119c
@donbarbos
Use ''
6ebb911
@donbarbos
Merge branch 'main' into issue-131178-pickle
230e256
@aisk aisk added the skip news label Mar 16, 2025
picnixz
picnixz reviewed Mar 16, 2025
View reviewed changes
Comment thread Lib/test/test_pickle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz previously approved these changes Mar 30, 2025
View reviewed changes
Comment thread Lib/test/test_pickle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 30, 2025
picnixz
picnixz reviewed Mar 30, 2025
View reviewed changes
Comment thread Lib/test/test_pickle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz dismissed their stale review March 30, 2025 11:28

Hit the wrong button

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting merge labels Mar 30, 2025
@donbarbos
Add suggestion
864f656
picnixz
picnixz reviewed Mar 31, 2025
View reviewed changes
Comment thread Lib/test/test_pickle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pickle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@donbarbos
Add suggestions
6856918
picnixz
picnixz approved these changes Mar 31, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 31, 2025
@picnixz picnixz self-assigned this Apr 6, 2025
@picnixz
Merge branch 'main' into issue-131178-pickle
a6180e4
@picnixz
picnixz enabled auto-merge (squash) April 6, 2025 14:37
@picnixz
picnixz merged commit f247e1d into python:main Apr 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@picnixz picnixz

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@donbarbos @picnixz @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.