GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131331: rename `not` field to `invert` for C++ extension modules by picnixz · Pull Request #131334 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Mar 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @brandtbucher

  • Issue: Cannot include cpython/Include/internal/pycore_optimizer.h in C++ extension due to use of protected C++ keyword "not" #131331

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
rename not field to not_ for C++ extension modules
e3987b0
@picnixz picnixz added the skip news label Mar 16, 2025
@picnixz
picnixz requested a review from markshannon as a code owner March 16, 2025 17:43
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 16, 2025
Cannot include cpython/Include/internal/pycore_optimizer.h in C++ extension due to use of protected C++ keyword "not" #131331
Closed
@picnixz picnixz added the topic-JIT label Mar 16, 2025
@picnixz
picnixz requested a review from brandtbucher March 16, 2025 17:45
brandtbucher
brandtbucher reviewed Mar 18, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename it to invert, please?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz
picnixz commented Mar 19, 2025
View reviewed changes
Comment thread Include/internal/pycore_optimizer.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_symbols.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
rename not_ to invert instead
2a1f4e4
@picnixz picnixz changed the title gh-131331: rename not field to not_ for C++ extension modules gh-131331: rename not field to invert for C++ extension modules Mar 19, 2025
@picnixz

picnixz commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

@brandtbucher Done! I'm leaving for a few days and I'll be offline. So if you want to change something, feel free to direclty edit my PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher
brandtbucher approved these changes Mar 20, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 20, 2025
@brandtbucher
brandtbucher merged commit 883c2f6 into python:main Mar 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 20, 2025
@picnixz
picnixz deleted the fix/jit/not-in-cpp-131331 branch March 22, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.