GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127833: lexical analysis: Improve section on Names by encukou · Pull Request #131474 · python/cpython

Conversation

@encukou

@encukou encukou commented Mar 19, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use consistent terminology: "names" are "identifiers", "keywords", and "soft keywords".
Start with the simple case (ASCII), then get more and more technical.
Define NAME in the formal lexical grammar.
Exclude keywords in the identifier definition.

  • Issue: Align the grammar documentation with Python's actual grammar #127833

📚 Documentation preview 📚: https://cpython-previews--131474.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
encukou added 2 commits March 19, 2025 17:58
@encukou
Start on the Identifiers section
3bace0a
@encukou
Lexical analysis: improve section on names
1b4e8fa
@encukou encukou added docs Documentation in the Doc dir skip news labels Mar 19, 2025
@encukou
encukou requested review from AA-Turner and willingc as code owners March 19, 2025 17:04
@github-project-automation github-project-automation Bot added this to Docs PRs Mar 19, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 19, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 19, 2025
StanFromIreland
StanFromIreland reviewed Mar 19, 2025
View reviewed changes
Comment thread Doc/reference/lexical_analysis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/reference/lexical_analysis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/reference/lexical_analysis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/reference/lexical_analysis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Petr Viktorin Stan Ulbrych
Update Doc/reference/lexical_analysis.rst
4f33459 
Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Mar 20, 2025
Align the grammar documentation with Python's actual grammar #127833
Open
Petr Viktorin added 2 commits May 7, 2025 16:29
Petr Viktorin
Apply suggestions from code review
912bf00
Petr Viktorin
Use an inline link for DerivedCoreProperties.txt
e6101d1
@encukou encukou added the needs backport to 3.14 bugs and security fixes label May 7, 2025
StanFromIreland
StanFromIreland approved these changes May 7, 2025
View reviewed changes
@terryjreedy

ghost commented May 11, 2025

Copy link
Copy Markdown
Member

I like the re-arrangement and separation of identifier and keyword.
encukou reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

ghost commented May 16, 2025

Copy link
Copy Markdown
Member Author

Thanks for the reviews!
I plan to merge on Wednesday if there are no objections.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit c7364f7 into python:main May 21, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 21, 2025
@miss-islington-app

ghost commented May 21, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 21, 2025
@encukou
encukou deleted the lex-analysis-names branch May 21, 2025 14:01
@bedevere-app

ghost commented May 21, 2025

Copy link
Copy Markdown

GH-134423 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
@miss-islington-app

ghost commented May 21, 2025

Copy link
Copy Markdown

Sorry @encukou, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport using cherry_picker on the command line.

cherry_picker c7364f79b2fb01c251e22115875a46a2ec134dcd 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou May 21, 2025
@encukou encukou mentioned this pull request Jun 18, 2025
Reword the Lexical Analysis chapter of the docs #135676
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@willingc willingc Awaiting requested review from willingc willingc is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @terryjreedy @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.