GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-131498: Remove conditional stack effects by markshannon · Pull Request #131499 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Mar 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A bit more simplification of the code generator before implementing TOS caching.

  • Issue: Top-of-stack caching in the interpreter #131498

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 3 commits March 20, 2025 10:45
@markshannon
Remove conditional stack effects -- We no longer need them
e0d8c95
@markshannon
Update test
accf4c9
@markshannon
Merge branch 'main' into remove-conditional-stack-effects
fef91dc
@markshannon
markshannon requested a review from Fidget-Spinner as a code owner March 20, 2025 11:57
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 20, 2025
Top-of-stack caching in the interpreter #131498
Closed
@markshannon
Add missing include
6b3bbf1
@markshannon markshannon added the skip news label Mar 20, 2025
@markshannon
Add missing #includes
dfaba30
@markshannon
markshannon requested a review from ericsnowcurrently as a code owner March 20, 2025 12:13
@markshannon
Add jit includes
7add005
@markshannon
markshannon requested review from brandtbucher and savannahostrowski as code owners March 20, 2025 14:01
markshannon added 2 commits March 20, 2025 14:03
@markshannon
Merge branch 'main' into remove-conditional-stack-effects
757f820
@markshannon
Add more JIT includes
b6ab21e
iritkatriel
iritkatriel approved these changes Mar 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 20, 2025
@markshannon
markshannon merged commit 7ebd71e into python:main Mar 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 20, 2025
@markshannon
markshannon deleted the remove-conditional-stack-effects branch March 20, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.