GeezerVison

All commit authors signed the Contributor License Agreement.

It seems for the benchmarks handling large text, there's a consistent slowdown. Could you plot a chart of running the function with inputs of different sizes? Perhaps take the unicodeobject file and profile the first 500 lines, then the first 1000, 1500, etc, for this PR and the version using min/max.

A

It stays a consistently slower by 5-8% except for long lines test

From additional testing, this way is slightly faster in the ranges where the lines are between 1-18.

after analyzing all the function documentation in the Python codebase the average documentation length seems to be the following https://gist.github.com/Marius-Juston/08c574901317ee40837ab87ce0855685:

( excluding all 1 line comments )

so technically, this implementation is slightly faster for the average documentation length ( now is this performance increase really worth it, no probably not lol )

I'm against this change not only because it's harder to read but also because it only offers an overall <10% speed-up. In general, we accept optimizations exceeding that threshold.

@eendebakpt with the new changes:

Small values

Large file

So on the large files we get 0 improvement, a 13% slight improvement on the synthetic test benches and on smaller values

I'm against this change not only because it's harder to read but also because it only offers an overall <10% speed-up. In general, we accept optimizations exceeding that threshold.

Agreed that this optimization is most likely not necessary, though this is very slightly more efficient memory wise since it does not have a non_blank_lines variable so it technically only duplicates the lines variable only twice rather than 3 times like in the current implementation ( in real world this is most definitively not really a problem just a thought )

Makes sense. I am just having so much fun doing this it is definitely hard to stop lol!

Closing this down then! ( I will be putting a feature request for the min_max implementation)

I will be putting a feature request for the min_max implementation

I think it's already been proposed but rejected so search through issues and https://discuss.python.org/c/ideas/6 first.

I think it's already been proposed but rejected so search through issues and https://discuss.python.org/c/ideas/6 first.

I think I found it, the https://discuss.python.org/t/minmax-function-alongside-min-and-max/2834/73 issue got closed down. It seems like it got stale and just ignored? A shame.

Feel free to open a new thread referencing the one you found. Personally I'd suggest statistics.min_max. It might be useful to identify a few motivating examples in the stdlib / popular packages -- this will be one of the first questions you're asked on Discourse.

A