GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105499: typing: Remove an unused function by JelleZijlstra · Pull Request #131946 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Mar 31, 2025

Copy link
Copy Markdown
Member

Leftover from #105511 I believe. GitHub code search found no usages other
than copies of typing.py and lists of stdlib functions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
typing: Remove an unused function
8d9d071 
Leftover from python#105511 I believe. GitHub code search found no usages other
than copies of typing.py and lists of stdlib functions.
@JelleZijlstra JelleZijlstra added skip issue skip news labels Mar 31, 2025
@JelleZijlstra
JelleZijlstra requested a review from AlexWaygood as a code owner March 31, 2025 16:36
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 31, 2025
@AlexWaygood

AlexWaygood commented Mar 31, 2025

Copy link
Copy Markdown
Member

there's now only one usage of _deduplicate_unhashable with this change; could consider inlining it at the callsite?
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
inline
7c0dd99
@JelleZijlstra

JelleZijlstra commented Mar 31, 2025

Copy link
Copy Markdown
Member Author

Good point, done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Mar 31, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 31, 2025
@JelleZijlstra
unused imports
a6885f7
@JelleZijlstra

JelleZijlstra commented Mar 31, 2025

Copy link
Copy Markdown
Member Author

Also noticed some unused imports, so removed those too
AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Mar 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Maybe you should update the title, e.g., gh-105499: remove unused bits post gh-105511
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra changed the title typing: Remove an unused function gh-105499: typing: Remove an unused function Mar 31, 2025
@JelleZijlstra
JelleZijlstra merged commit 0f511d8 into python:main Mar 31, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JelleZijlstra @AlexWaygood @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.