GeezerVison is showing github.com — GH-131498: Cases generator: Parse down to C statement level. by markshannon · Pull Request #131948 · python/cpython
Conversation
markshannon
commented
Mar 31, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR enhances the cases generator parser to parse instructions and labels down to C statement level.
This:
- Simplifies the rest of the code generator.
- Enables us to treat
#if conditionals like normal if statements ensuring that the free-threading and default builds have the same properties and are properly understood by the code generator.
Because we are now parsing the source, rather than simply tokenizing it, the output no longer contains the comments present in the original.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
stonebig reacted with heart emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
|
raise NotImplementedError()
|
|
|
|
|
|
|
|
|
@dataclass
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to reduce memory footprint, use slots=True
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is worth it to save a few kbytes.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
picnixz
picnixz left review comments
Fidget-Spinner
Awaiting requested review from Fidget-Spinner
Fidget-Spinner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.