GeezerVison

$ wc -l /usr/lib/python3.{8,9,1*}/ast.py 
   549 /usr/lib/python3.8/ast.py
  1602 /usr/lib/python3.9/ast.py
  1709 /usr/lib/python3.10/ast.py
  1752 /usr/lib/python3.11/ast.py
  1840 /usr/lib/python3.12/ast.py
  1871 /usr/lib/python3.13/ast.py
  1777 /usr/lib/python3.14/ast.py

And with this PR we are back down to 671 lines. The massive jump is from when unparse was added.

This feels nice all on its own, to avoid so much code that is often not needed.

• I'm not sure we need to keep getattr support for the private attributes, like the Precedence enum and the various constants. I'd do that only if there's evidence they are being used in third-party code, especially widely used packages. Otherwise we just make our lives harder if we want to refactor the unparse code in the future.

Reverted.

• An alternative approach could be to make ast a package, with the unparse code in ast/_unparse.py and the rest of the functionality in ast/__init__.py. Pro: Doesn't need a new top-level module; avoids the (probably theoretical) compatibility concern that someone could have their own top-level _ast_unparse module that interferes with the stdlib one. Con: Makes the directory structure more complex.

I'd suggest doing that in a follow-up PR, if desirable. I think for now this is the simplest approach. If it provides any reassurance, GitHub has no results for the _ast_unparse.py file, so I think approaching 0% chance of breaking things in that regard.

Oh, I was reviewing the change while it has been merged :-) Well, it LGTM. I had minor suggestions, but they don't matter anymore.

Nice optimization.

Oh, I was reviewing the change while it has been merged :-) Well, it LGTM. I had minor suggestions, but they don't matter anymore.

Sorry! Happy to open a follow-up PR for any of your suggestions?

Benchmark: 13.1 ms => 18.8 ms (-5.7 ms).

Before:

$ hyperfine --warmup 1 "./python -c 'import ast'"
Benchmark 1: ./python -c 'import ast'
  Time (mean ± σ):      18.8 ms ±   0.6 ms    [User: 16.8 ms, System: 2.0 ms]
  Range (min … max):    17.9 ms …  20.3 ms    138 runs

After:

$ hyperfine --warmup 1 "./python -c 'import ast'"
Benchmark 1: ./python -c 'import ast'
  Time (mean ± σ):      13.1 ms ±   0.5 ms    [User: 11.1 ms, System: 2.0 ms]
  Range (min … max):    12.5 ms …  14.4 ms    206 runs

Sorry! Happy to open a follow-up PR for any of your suggestions?

Well, I don't know if it would better, but an alternative to adding __dir__() and __getattr__() functions is to add such wrapper function:

def unparse(ast_obj):
    import _ast_unparse
    return _ast_unparse.unparse(ast_obj)

Well, I don't know if it would better, but an alternative to adding dir() and getattr() functions is to add such wrapper function:

The __dir__ implementation in particular seems a bit fragile. What happens if somebody introduces another stdlib dependency (besides sys) and forgets to exclude it in __dir__ ?

Hmm, unless I am missing something, it seems that with this change unparse is not being included in star imports?

❯ python
Python 3.12.7 (main, Oct  1 2024, 00:00:00) [GCC 13.3.1 20240913 (Red Hat 13.3.1-3)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from ast import *
>>> unparse
<function unparse at 0x7f7f8ebc9c60>

❯ ./python
Python 3.14.0a6+ (heads/main:f20f02e6b58, Apr  2 2025, 17:41:39) [GCC 13.3.1 20240913 (Red Hat 13.3.1-3)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from ast import *
>>> unparse
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    unparse
NameError: name 'unparse' is not defined. Did you mean: 'parse'?

I think (untested) that the __getattr__ approach is faster for the second access of unparse on, as it adds unparse to the module globals, whereas the proposed wrapper executes the (cached) import _ast_unparse each time. I'm happy to update __dir__, though.

I've opened #132024 for follow-ups.

Alternative followup in #132025.