GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85302: Add support for BTPROTO_SCO on FreeBSD by serhiy-storchaka · Pull Request #131981 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 1, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

BTPROTO_SCO has been supported on FreeBSD since 2008.

  • Issue: Improve/fix FreeBSD Bluetooth socket support #85302

📚 Documentation preview 📚: https://cpython-previews--131981.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-85302: Add support for BTPROTO_SCO on FreeBSD
2debf1e 
BTPROTO_SCO has been supported on FreeBSD since 2008.
@serhiy-storchaka serhiy-storchaka added the OS-freebsd label Apr 1, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner April 1, 2025 15:26
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 1, 2025
Improve/fix FreeBSD Bluetooth socket support #85302
Closed
@serhiy-storchaka

serhiy-storchaka commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 1, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2debf1e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Apr 2, 2025
View reviewed changes

@vstinner vstinner left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, socket.BTPROTO_SCO constant does not exist on FreeBSD which makes the whole change useless.

The problem is that on my FreeBSD 14.1 VM, the constant is not defined anywhere.grep finds nothing:

$ grep BTPROTO_SCO /usr/include/ -R

Are you sure that FreeBSD supports BTPROTO_SCO?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka

serhiy-storchaka commented Apr 2, 2025

Copy link
Copy Markdown
Member Author

Indeed, it is defined as BLUETOOTH_PROTO_SCO. I'll fix this, but first we need to add tests. See #132023.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added 2 commits April 4, 2025 17:23
@serhiy-storchaka
Merge branch 'main' into BTPROTO_SCO-FreeBSD
69840d6
@serhiy-storchaka
Define BTPROTO_SCO.
a62570a
@serhiy-storchaka

serhiy-storchaka commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2debf1e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 4, 2025

Copy link
Copy Markdown
Member

You need to update your PR to use BLUETOOTH_PROTO_SCO constant, no?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

Did I forget to push my changes? Thanks for noticing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit a62570a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131981%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Define _BT_SCO_MEMB on FreeBSD.
10ee7ae
@python-cla-bot

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Merge branch 'main' into BTPROTO_SCO-FreeBSD
e22cbcf
@serhiy-storchaka
serhiy-storchaka merged commit e5f8b2c into python:main Apr 11, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 11, 2025
@serhiy-storchaka
serhiy-storchaka deleted the BTPROTO_SCO-FreeBSD branch July 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-freebsd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.