GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-131885: Document `/` for `codecs` functions by donbarbos · Pull Request #131992 · python/cpython Conversation
|
| def __new__(cls, encode, decode, streamreader=None, streamwriter=None, | |
| incrementalencoder=None, incrementaldecoder=None, name=None, | |
| *, _is_text_encoding=None): |
inspect.signature(codecs.CodecInfo):
<Signature (encode, decode, streamreader=None, streamwriter=None, incrementalencoder=None, incrementaldecoder=None, name=None, *, _is_text_encoding=None)>
I don't think this should be documented, but I thought I'd point it out just in case.
2. I'm not a fan of using / and I also want to point out that it doesn't seem natural for codecs functions to use positional-only arguments, since they are only used in the functions that I updated. I would suggest getting rid of / in the code instead of documenting it.
📚 Documentation preview 📚: https://cpython-previews--131992.org.readthedocs.build/
Sorry, something went wrong.
There was an error while loading. Please reload this page.
/ for codecs functions/ for codecs functions
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged, thank you. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.