GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-59705: Fix solaris detection in test_set_name by kulikjak · Pull Request #132012 · python/cpython

Conversation

@kulikjak

@kulikjak kulikjak commented Apr 2, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

sys.platform on Solaris/Illumos starts with "sunos" rather than "solaris".

  • Issue: Python should support exporting thread names to the OS #59705

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kulikjak
pythongh-59705: Fix solaris detection in test_set_name
6ade825
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 2, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 2, 2025
Python should support exporting thread names to the OS #59705
Closed
@kulikjak kulikjak mentioned this pull request Apr 2, 2025
gh-59705: Add _thread.set_name() function #127338
Merged
vstinner
vstinner approved these changes Apr 2, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 2, 2025
@vstinner vstinner added the skip news label Apr 2, 2025
@vstinner
vstinner merged commit e808531 into python:main Apr 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 2, 2025
@vstinner

vstinner commented Apr 2, 2025

Copy link
Copy Markdown
Member

Oops, thanks for the fix! It's now merged.
kulikjak reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kulikjak @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.